Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Work around #597 by acknowledging that winbuild is deprecated #598

Closed

Conversation

phenaproxima
Copy link
Contributor

What does this PR do?

It is a short-term workaround for #597. According to the error message detailed in that issue, you can use winbuild anyway if you pass WINBUILD_ACKNOWLEDGE_DEPRECATED=yes. So that's what this does.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@phenaproxima phenaproxima changed the title Work around #597 by acknowleding that winbuild is deprecated Work around #597 by acknowledging that winbuild is deprecated Feb 6, 2025
@crazywhalecc crazywhalecc added bug Something isn't working duplicate This issue or pull request already exists wontfix This will not be worked on and removed duplicate This issue or pull request already exists labels Feb 6, 2025
@crazywhalecc
Copy link
Owner

This bug has been fixed by #600 .

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants