Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix windows curl build (using cmake) #600

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

crazywhalecc
Copy link
Owner

What does this PR do?

Fix #597, #598

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added bug Something isn't working kind/dependency Issues related to dependencies os/windows Things only for Windows labels Feb 6, 2025
@crazywhalecc crazywhalecc merged commit 95d7414 into main Feb 6, 2025
11 checks passed
@crazywhalecc crazywhalecc deleted the fix/windows-curl branch February 6, 2025 14:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working kind/dependency Issues related to dependencies os/windows Things only for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can no longer build for Windows on GitHub Actions due to a deprecation error while building cURL
1 participant