-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Defer something-for-nothing culling for taker orders until the order is unmatched #555
Comments
I wonder if |
The |
Implemented, merged. |
The code here culls orders which would allow a counterparty to get something for nothing due to rounding. However, if the order being culled is a taker order, this culling should be deferred until the taker order doesn't match (and any unfilled remnant would become a maker order).
Put another way, the culling is currently being applied to taker orders, and it really only makes sense to apply it for maker orders.
As the order issued by the buyback code under development for #538 is a taker order with a very small price, correctly handling this case is a prerequisite for that feature.
The text was updated successfully, but these errors were encountered: