Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Integer overflow bug in database_fixture waiting for zero blocks #559

Closed
theoreticalbts opened this issue Feb 8, 2016 · 1 comment
Closed

Integer overflow bug in database_fixture waiting for zero blocks #559

theoreticalbts opened this issue Feb 8, 2016 · 1 comment
Assignees
@theoreticalbts
Milestone
next2

Comments

@theoreticalbts
Copy link
Contributor

When get_slot_at_time() on [this line] returns 0 (due to having requested timestamp in the present/past), there is a possibility for integer overflow. Encountered this when writing buyback test which depends on both #538 #555 and I put in

generate_blocks( HARDFORK_538_TIME );
generate_blocks( HARDFORK_555_TIME );

to document this fact. When the two constants have the same value, the second should be a no-op, but it throws an exception instead.
theoreticalbts added a commit that referenced this issue Feb 8, 2016
@theoreticalbts
database_fixture.cpp: Fix integer overflow bug waiting for zero blocks …
10fca25 
…#559
@theoreticalbts theoreticalbts added this to the next2 milestone Feb 8, 2016
@theoreticalbts theoreticalbts self-assigned this Feb 8, 2016
theoreticalbts added a commit that referenced this issue Feb 9, 2016
@theoreticalbts
Merge many bugfix branches into develop
078e63a 
Merged:

492-bugfix-open-fail #492
523-bugfix-multiple-blind-xfer #523
537-cleanup-remove-operation_get_required_authorities #537
540-cleanup-settle-volume-spam #540
542-bugfix-cancel-fee #542
557-bugfix-pts-address #557
559-test-fix-zero-block-wait #559
561-bugfix-serializer-build-broken #561
562-bugfix-unreflected-fields #562
@theoreticalbts
Copy link
Contributor Author

Fixed, merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@theoreticalbts theoreticalbts

Labels
None yet
Projects
None yet
Milestone
next2
Development

No branches or pull requests
1 participant
@theoreticalbts