-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cache TTL doesn't seem to work #12
Comments
Thank you so much! This has been bugging me but I have not had time to dive in. |
Merged
https://github.com/cvburgess/SQLDataSource/releases/tag/v0.1.5 Should resolve the cache TTL issue. CC: @tab00 |
Thanks! Confirmed that it's fixed. 🎉 Might want to update the README example:
The Apollo package looks for a |
Oh thats great to know - would you mind opening a PR for that? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Hey thanks for this package!
I'm running v0.1.4 and noticed that when using
getBatchedAndCached
, passing a TTL doesn't do anything, and the set value seems to live in the cache forever. I tried:I think the issue might be that
apollo-server-caching@0.1.2
doesn't actually use a TTL inset
.I can get around it by installing
apollo-server-caching@0.3.1
and passing in{ cache: new InMemoryLRUCache() }
ininitialize
.Not sure if I'm missing something, but I think you can just update the dependency.
The text was updated successfully, but these errors were encountered: