Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix ttl #15

Closed
lorensr opened this issue Apr 5, 2019 · 3 comments · Fixed by #16
Closed

Fix ttl #15

lorensr opened this issue Apr 5, 2019 · 3 comments · Fixed by #16

Comments

@lorensr
Copy link
Contributor

lorensr commented Apr 5, 2019

https://github.com/cvburgess/SQLDataSource/blob/master/SQLCache.js#L24-L40

Last param to .set is an object:

https://github.com/apollographql/apollo-server/tree/master/packages/apollo-server-caching#implementing-your-own-cache

Also, ttl is in seconds, so example in README shouldn't multiply by 1000
@cvburgess
Copy link
Owner

Yup, see the discussion on #12

Please feel free to open a PR - or i will try to get to it as soon as possible.

cvburgess added a commit that referenced this issue Apr 5, 2019
@cvburgess
fix ttl vs options obj
7fac4ea 
closes #15
closes #12
@cvburgess cvburgess mentioned this issue Apr 5, 2019
Merged
@cvburgess
Copy link
Owner

Does this PR fix your issue @lorensr #16 ?

cvburgess added a commit that referenced this issue Apr 5, 2019
@cvburgess
1.1.6 12: fix ttl vs options obj (#16)
410b33b 
- Fix issue setting TTL on cache requests [#15]
@cvburgess
Copy link
Owner

Released to NPM https://github.com/cvburgess/SQLDataSource/releases/tag/v0.1.6

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

12: fix ttl vs options obj cvburgess/SQLDataSource
2 participants
@lorensr @cvburgess