Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use shared_ptr holder for Problem #45

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

sarlinpe
Copy link
Member

@B1ueber2y Without this fix, the following code results in a segfault for me:

ba = pycolmap.BundleAdjuster()
pb = ba.problem
del pb

The shared pointer returned by BundleAdjuster.problem is lost if pyceres.Problem is not declared to use the shared pointer holder.

@B1ueber2y B1ueber2y self-assigned this May 26, 2024
@B1ueber2y
Copy link
Member

Nice catch. Indeed, this should be fixed.

@sarlinpe sarlinpe merged commit 807ee5d into main May 27, 2024
12 checks passed
@sarlinpe sarlinpe deleted the sarlinpe/shared-ptr-problem branch May 27, 2024 07:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants