Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix crash on large GitHub "id" values #108

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Fix crash on large GitHub "id" values #108

merged 1 commit into from
Jul 8, 2020

Conversation

brentwatson
Copy link

@brentwatson brentwatson commented Jul 8, 2020 •
edited
Loading

Recently experienced this crash:

com.squareup.moshi.JsonDataException: Expected an int but was 2185200023 at path $.danger.github.issue.labels[0].id

Looks like we have a PR with an id value larger than Int.MAX_VALUE (2147483647). Future proofing by updating all id values from int to long.

@danger-public
Copy link

Warnings
⚠️

Any Changes To Library Code Should Be Reflected In The Changelog.

Please Consider Adding A Note There And Adhere To The Changelog Guidelines.

Generated by 🚫 Danger Kotlin against 83cb38b

f-meloni
f-meloni approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you really much

@f-meloni f-meloni merged commit e2daf34 into danger:master Jul 8, 2020
@brentwatson brentwatson mentioned this pull request Jul 8, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brentwatson @danger-public @f-meloni