Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix crash on large GitHub "id" values #108

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Fix crash on large GitHub "id" values #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/GitHub.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ data class GitHubPR(
*/
@JsonClass(generateAdapter = true)
data class GitHubTeam(
val id: Int,
val id: Long,
val name: String
)

Expand Down Expand Up @@ -238,7 +238,7 @@ data class GitHubMergeRef(
*/
@JsonClass(generateAdapter = true)
data class GitHubRepo(
val id: Int,
val id: Long,
val name: String,
@Json(name = "full_name") val fullName: String,
@Json(name = "private") val isPrivate: Boolean,
Expand Down Expand Up @@ -272,7 +272,7 @@ enum class GitHubReviewState(val value: String) {
@JsonClass(generateAdapter = true)
data class GitHubReview(
val user: GitHubUser,
val id: Int?,
val id: Long?,
val body: String?,
@Json(name = "commit_id") val commitId: String?,
val state: GitHubReviewState?
Expand Down Expand Up @@ -333,7 +333,7 @@ enum class GitHubIssueState(val value: String) {
*/
@JsonClass(generateAdapter = true)
data class GitHubIssue(
val id: Int,
val id: Long,
val number: Int,
val title: String,
val user: GitHubUser,
Expand Down Expand Up @@ -375,7 +375,7 @@ data class GitHubIssue(
}

override fun hashCode(): Int {
var result = id
var result = id.hashCode()
result = 31 * result + number
result = 31 * result + title.hashCode()
result = 31 * result + user.hashCode()
Expand All @@ -402,7 +402,7 @@ data class GitHubIssue(
*/
@JsonClass(generateAdapter = true)
data class GitHubIssueLabel(
val id: Int,
val id: Long,
val url: String,
val name: String,
val color: String
Expand All @@ -426,7 +426,7 @@ enum class GitHubUserType {
*/
@JsonClass(generateAdapter = true)
data class GitHubUser(
val id: Int,
val id: Long,
val login: String,
val type: GitHubUserType,
@Json(name="avatar_url")
Expand Down Expand Up @@ -460,7 +460,7 @@ enum class GitHubMilestoneState(val value: String) {
*/
@JsonClass(generateAdapter = true)
data class GitHubMilestone(
val id: Int,
val id: Long,
val number: Int,
val state: GitHubMilestoneState,
val title: String,
Expand Down
2 changes: 1 addition & 1 deletion danger-kotlin-library/src/test/kotlin/systems/danger/kotlin/GitHubParsingTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class GitHubParsingTests {
@Test
fun testItCorrectlyParsesTheIssue() {
with(github.issue) {
assertEquals(167696965, id)
assertEquals(2190001234, id)
assertEquals(609, number)
assertEquals("Xcode updates", title)
assertEquals(
Expand Down
2 changes: 1 addition & 1 deletion danger-kotlin-library/src/test/resources/githubDangerJSON.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@
"comments_url": "https://api.github.com/repos/artsy/eidolon/issues/609/comments",
"events_url": "https://api.github.com/repos/artsy/eidolon/issues/609/events",
"html_url": "https://github.com/artsy/eidolon/pull/609",
"id": 167696965,
"id": 2190001234,
"number": 609,
"title": "Xcode updates",
"user": {
Expand Down