-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
The AnimationController class uses WebKit specific APIs #101
Comments
This comment was originally written by drfibonacci@google.com Thanks! Please attach the patch so we can take a look. Removed Type-Defect label. |
This comment was originally written by ehsan.akhgari...@gmail.com http://codereview.chromium.org/8277005 Do I need to attach the patch here too? |
This comment was originally written by ehsan.akhga...@gmail.com Ping? |
This comment was originally written by drfibonacci@google.com Set owner to @dgrove. |
Set owner to @jacob314. |
This was fixed awhile ago. Added Fixed label. |
…, html, http, lints, markdown, matcher, mockito, path, protobuf, shelf, source_maps, source_span, sync_http, test, test_reflective_loader, tools, usage, vector_math, webdriver, webkit_inspection_protocol, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/5ac2ba1..1864048): 1864048 2023-05-03 Devon Carew added package topics to the pubspec file (#242) db229fb 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#241) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d5f8837..1b86d3c): 1b86d3c 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#72) characters (https://github.com/dart-lang/characters/compare/b306414..2af6783): 2af6783 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#81) cli_util (https://github.com/dart-lang/cli_util/compare/6c318c2..7234f17): 7234f17 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#82) collection (https://github.com/dart-lang/collection/compare/9db854d..26e3e67): 26e3e67 2023-05-03 Lasse R.H. Nielsen Accept SDK version above 3.0. (#281) file (https://github.com/google/file.dart/compare/72a67c3..b905180): b905180 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#212) 8158a35 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#218) html (https://github.com/dart-lang/html/compare/0438b26..5d87dc8): 5d87dc8 2023-05-03 Devon Carew added package topics to the pubspec file (#215) http (https://github.com/dart-lang/http/compare/877f134..f581ff7): f581ff7 2023-05-01 Nate Bosch Prepare to publish (#914) fa53651 2023-05-01 Brian Quinlan Document that RetryClient may consume a lot of memory (#915) lints (https://github.com/dart-lang/lints/compare/ba7d75e..17276ec): 17276ec 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#116) markdown (https://github.com/dart-lang/markdown/compare/82b050d..6db8fc1): 6db8fc1 2023-05-02 Jonas Finnemann Jensen Prepare 7.1.0 (#538) matcher (https://github.com/dart-lang/matcher/compare/7228c26..5890f2b): 5890f2b 2023-05-01 Nate Bosch Expand bound for `test_api` dependency (#219) mockito (https://github.com/dart-lang/mockito/compare/beb45ba..56173fa): 56173fa 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#626) path (https://github.com/dart-lang/path/compare/23e3319..1552cfd): 1552cfd 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#142) 82ddc60 2023-05-01 Jonathan fixed mistake in split method doc comment (#141) protobuf (https://github.com/dart-lang/protobuf/compare/b90a4c4..9d7cf0d): 9d7cf0d 2023-05-01 Kevin Moore Update Github Actions (#827) shelf (https://github.com/dart-lang/shelf/compare/9a792b4..79e3cee): 79e3cee 2023-05-03 Devon Carew add package topics for package:shelf_router_generator (#346) 25861e5 2023-05-03 Devon Carew add topics to the pubspec files (#345) source_maps (https://github.com/dart-lang/source_maps/compare/0a4b030..f0a8506): f0a8506 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#77) source_span (https://github.com/dart-lang/source_span/compare/905a167..69fa991): 69fa991 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#97) sync_http (https://github.com/dart-lang/sync_http/compare/660ad87..c3d6ad4): c3d6ad4 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#36) test (https://github.com/dart-lang/test/compare/b252463..9484592): 9484592a 2023-05-02 Nate Bosch Prepare to publish checks (#2005) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/a85a930..d1b763f): d1b763f 2023-05-01 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#48) tools (https://github.com/dart-lang/tools/compare/516995e..b55f0d4): b55f0d4 2023-05-02 Elias Yishak `pddFlag` removal + tests for pdd restricted instance of `Analytics` (#86) usage (https://github.com/dart-lang/usage/compare/f97752f..929a4e3): 929a4e3 2023-05-02 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#193) vector_math (https://github.com/google/vector_math.dart/compare/7dec984..e3de8da): e3de8da 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#291) webdriver (https://github.com/google/webdriver.dart/compare/562aa06..d0f78d0): d0f78d0 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#273) 1ef3348 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#275) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/8401098..39a3c29): 39a3c29 2023-05-01 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#102) 5555c53 2023-05-01 dependabot[bot] Bump nanasess/setup-chromedriver from 1.1.0 to 2.0.0 (#101) 9adce2a 2023-05-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#103) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/5f392a1..e05282b): e05282b 2023-05-02 Jonas Finnemann Jensen Prepare 2.1.1 release (#52) Change-Id: Iee7fd84d32ae37b76147d62c2268df19cf8db95b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300863 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
…string_scanner, test, test_descriptor, vector_math Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/06d7288..a04ac3e): a04ac3e8 2023-07-19 Sam Rawlins Format testing and fix static-type-parameter issue (#3465) a44ecebc 2023-07-19 Sam Rawlins Move validation-related tasks to package:args (#3463) 392812e4 2023-07-17 dependabot[bot] Bump analyzer from 5.13.0 to 6.0.0 (#3458) 642e8d8b 2023-07-17 Sam Rawlins Convert 'p' prefixes to 'path' in test/ (#3462) ecosystem (https://github.com/dart-lang/ecosystem/compare/2052a4c..27ff3e9): 27ff3e9 2023-07-19 Moritz Add debug message (#142) 02703ce 2023-07-18 Moritz Split commenting into new workflow (#141) a52ac63 2023-07-18 Moritz Finish renaming `coverage_web` (#140) ffa1ecb 2023-07-17 Moritz Health workflow updates (#134) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/515612e..098bafc): 098bafc 2023-07-20 fzyzcjy Update pubspec.yaml (#75) 7606fd1 2023-07-19 Polina Cherkasova Improve performance. (#98) e6778b3 2023-07-18 Polina Cherkasova Explain case when static object causes leaks. (#96) cca1d77 2023-07-18 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#86) markdown (https://github.com/dart-lang/markdown/compare/ee4e1b3..faabb1a): faabb1a 2023-07-17 Kevin Moore Bump pkg:http (dev) dependency (#551) mime (https://github.com/dart-lang/mime/compare/bdb66bd..799b398): 799b398 2023-07-18 Kevin Moore update lints, require Dart 3 (#101) d17e3ed 2023-07-18 Kevin Moore blast_repo fixes (#100) native (https://github.com/dart-lang/native/compare/7c474e1..2598ac6): 2598ac6 2023-07-20 Daco Harkes Package name spacing (#101) 3d73b4a 2023-07-19 Daco Harkes [native_assets_builder] Builder `out/` folder (#99) 6308330 2023-07-19 Daco Harkes Remove compiled files (#92) string_scanner (https://github.com/dart-lang/string_scanner/compare/35657e2..413b57a): 413b57a 2023-07-18 Kevin Moore Require Dart 3, update lints (#61) 53690da 2023-07-18 Kevin Moore blast_repo fixes (#60) test (https://github.com/dart-lang/test/compare/a92b5bb..37e54e3): 37e54e32 2023-07-19 Nate Bosch Handle initial message entirely within conditional (#2067) e76bffe8 2023-07-19 Nate Bosch Expand dom interop to cover more uses (#2066) 8bc188f7 2023-07-18 Lukas Klingsbo docs: Fix grammar and typos in Checks readme (#2058) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/54a4c59..36d8617): 36d8617 2023-07-18 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#53) vector_math (https://github.com/google/vector_math.dart/compare/c147038..048777a): 048777a 2023-07-19 moritzblume Fix rotation around Y axis (#262) 47a08ea 2023-07-17 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#293) Change-Id: Id8010082c818c995aa7968327f98f347ff45761d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315221 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
…ion, dartdoc, ecosystem, file, glob, html, http_multi_server, http_parser, json_rpc_2, mockito, package_config, protobuf, pub_semver, source_maps, source_span, sync_http, test_reflective_loader, usage, vector_math, web_socket_channel, webdriver Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/da56b18..5a4e16f): 5a4e16f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#254) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/f950bbf..159e671): 159e671 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#80) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/fde73cb..7d0d28e): 7d0d28e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#92) characters (https://github.com/dart-lang/characters/compare/ec844db..7633a16): 7633a16 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#86) collection (https://github.com/dart-lang/collection/compare/1a9b7eb..91afde4): 91afde4 2023-09-02 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#311) dartdoc (https://github.com/dart-lang/dartdoc/compare/695b218..a32ba3a): a32ba3a1 2023-09-05 Parker Lougheed Enable accidentally disabled reflective parameter test (#3490) 0c0cb4ed 2023-09-04 dependabot[bot] Bump actions/checkout from 3.5.3 to 4.0.0 (#3492) 08d8d9c4 2023-09-01 Sam Rawlins Implement much support for extension types (#3489) ecosystem (https://github.com/dart-lang/ecosystem/compare/89e58de..2e6c3ec): 2e6c3ec 2023-09-05 Hossein Yousefi Fix Publish Workflow (#162) 2e532e3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#161) file (https://github.com/google/file.dart/compare/5d9a602..a18ad1c): a18ad1c 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.6.0 (#228) glob (https://github.com/dart-lang/glob/compare/5b24393..9c1996f): 9c1996f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#82) html (https://github.com/dart-lang/html/compare/4060496..a1b193e): a1b193e 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#225) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/aa128cf..9d62ea3): 9d62ea3 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#57) http_parser (https://github.com/dart-lang/http_parser/compare/c14fbf6..d2d03e7): d2d03e7 2023-09-02 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#77) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/509f71e..50a3786): 50a3786 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#101) mockito (https://github.com/dart-lang/mockito/compare/f5abf11..412c0be): 412c0be 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#692) package_config (https://github.com/dart-lang/package_config/compare/981c49d..ae7ad83): ae7ad83 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#140) protobuf (https://github.com/dart-lang/protobuf/compare/5e8f36b..c16bc89): c16bc89 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.6.0 (#873) pub_semver (https://github.com/dart-lang/pub_semver/compare/028b435..f0be74a): f0be74a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#91) source_maps (https://github.com/dart-lang/source_maps/compare/97c4833..eb3d40a): eb3d40a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#81) source_span (https://github.com/dart-lang/source_span/compare/37735ae..48d0f57): 48d0f57 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#101) sync_http (https://github.com/dart-lang/sync_http/compare/c3d6ad4..8233f74): 8233f74 2023-09-01 Devon Carew Merge pull request #37 from google/dependabot/github_actions/actions/checkout-3.6.0 57dc02b 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.6.0 test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/0bfaad9..45c57d6): 45c57d6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#51) usage (https://github.com/dart-lang/usage/compare/09bb847..7b12d51): 7b12d51 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#197) vector_math (https://github.com/google/vector_math.dart/compare/88bada3..d54af8a): d54af8a 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.6.0 (#301) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/4d1b543..af945f1): af945f1 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#283) webdriver (https://github.com/google/webdriver.dart/compare/20ec47f..21976d6): 21976d6 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.6.0 (#279) 352b9b6 2023-09-01 dependabot[bot] Bump nanasess/setup-chromedriver from 1.1.0 to 2.2.0 (#278) Change-Id: I0b1f7a8851a7ee992d5b67a221ab523f55b51240 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324261 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/a32ba3a..adc76e6): adc76e6d 2023-09-06 Parker Lougheed Take advantage of a few Dart 3 features (#3491) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/098bafc..4616c8b): 4616c8b 2023-09-05 Polina Cherkasova Note about OverlayEntry. (#142) fd7d70f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#141) c6c1004 2023-09-01 Polina Cherkasova - (#139) 0298e20 2023-08-31 Polina Cherkasova Add a test specific rule. (#138) ea17fa4 2023-08-29 Polina Cherkasova Increase version of leak_tracker_flutter_testing (#136) 8f830d6 2023-08-29 Polina Cherkasova Update pubspec.yaml (#135) 8a54575 2023-08-29 Polina Cherkasova Enable connection to vm service for flutter testing and define matcher for reporting for memory allocations. (#128) 88a19a7 2023-08-28 Polina Cherkasova - (#133) 2070856 2023-08-24 Polina Cherkasova Add instruction to start tracking instances of ChangeNotifier earlier. (#130) eb6113a 2023-08-23 Polina Cherkasova Measure how memory is consumed by a test. (#114) 72264f7 2023-08-22 Polina Cherkasova Fix misspelling. (#131) 87c9e9e 2023-08-16 Polina Cherkasova Add debugging construcstors to LeakTrackingTestConfig, per leak type. (#129) b29547a 2023-08-15 Polina Cherkasova Create visibility for roadmap for leak_tracker. (#124) 23b15b6 2023-08-15 Polina Cherkasova Fix issue of using wrong settings for a phase. (#122) 713f646 2023-08-11 Polina Cherkasova Enable global configuration for leak tracking. (#121) 19b01cf 2023-08-10 Polina Cherkasova Create package leak_tracker_flutter_testing. (#119) 02d0b2f 2023-08-07 Polina Cherkasova Stop failing if object is disposed twice. (#117) 2026379 2023-08-04 Polina Cherkasova Remove not-published versions and increase leak_tracker version. (#116) 9bb71c6 2023-08-04 Polina Cherkasova Stop requiring registration of disposed objects. (#113) 8939456 2023-08-04 Polina Cherkasova Refactor dispatcher. (#115) 6f54f5a 2023-08-01 Polina Cherkasova Start vm service when needed. (#112) b045c5e 2023-08-01 Polina Cherkasova Reorganize leak tracker for better performance. (#106) 127b83c 2023-07-31 Polina Cherkasova Update TROUBLESHOOT.md (#108) 6dabd33 2023-07-31 Polina Cherkasova Simplify and clarify instructions to fix leaks. (#107) c53db68 2023-07-25 Polina Cherkasova Improve code structure. (#103) 10cce1a 2023-07-24 Polina Cherkasova Rename `gcCountBuffer` to `numberOfGcCycles`. (#101) 3a061a4 2023-07-21 Polina Cherkasova Improve doc comments. (#100) 6e3f57c 2023-07-21 Polina Cherkasova Fix and test cover case of customized `gcCountBuffer` (#99) 2152aab 2023-07-21 Polina Cherkasova Add details about hidden leaks. (#97) lints (https://github.com/dart-lang/lints/compare/da44af3..8d5f750): 8d5f750 2023-09-06 Devon Carew move the list of lint rules from the readme to a separate rules.md file (#145) native (https://github.com/dart-lang/native/compare/a2dfedc..387f894): 387f894 2023-09-06 Gabriel Terwesten [native_toolchain_c] Default handling for PIC/PIE compiler flags (#121) 0a4e5f8 2023-09-06 Gabriel Terwesten Add support for defines to `CBuilder` (#120) webdev (https://github.com/dart-lang/webdev/compare/fc876cb..9487a45): 9487a459 2023-09-05 Jacob Bang Update README.md to use `dart pub` instead of `pub` (#2195) 07367779 2023-08-31 Elliott Brooks Pass the package config directly to the load strategy instead of depending on an app entrypoint (#2203) 0044d753 2023-08-24 Jonas Termansen Fix conflicting webdev smoke package names. (#2202) 6183f270 2023-08-23 Elliott Brooks Allow client to specify a way to convert an absolute path into a g3-relative path (#2200) b244b899 2023-08-22 Elliott Brooks Allow client to specify how to find the package config (#2199) Change-Id: Ic00adc68ec01cd0cc6e27be665436de5095d8d07 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324801 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was originally filed by ehsan.ak...@gmail.com
This class uses the webkitRequestAnimationFrame, which means that it's only going to benefit from this API support on WebKit based browsers, and also it's not future compatible. I have a patch which first checks for the availability of requestAnimationFrame, and if that's not available, it falls back into checking Mozilla/WebKit/IE specific versions of the API.
The text was updated successfully, but these errors were encountered: