Skip to content

language/arithmetic_test times out on safari #3492

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
kasperl opened this issue Jun 11, 2012 · 10 comments
Closed

language/arithmetic_test times out on safari #3492

kasperl opened this issue Jun 11, 2012 · 10 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Milestone
M3

Comments

@kasperl
Copy link

kasperl commented Jun 11, 2012

Skipped in language_dart2js.status file.
@rakudrama
Copy link
Member

I suggest this for M1.

There are several language tests that fail on Safari.
A common thread is detecting null pointer or NSME.
Most are probably solved with changes similar to r10931

Added this to the M1 milestone.

@kasperl
Copy link
Author

kasperl commented Sep 3, 2012

Removed this from the M1 milestone.
Added this to the Later milestone.

@kasperl
Copy link
Author

kasperl commented Oct 17, 2012

Removed this from the Later milestone.

@kasperl
Copy link
Author

kasperl commented Oct 17, 2012

Added this to the M2 milestone.

@peter-ahe-google
Copy link
Contributor

Set owner to ngeoffray@google.com.
Removed Priority-Medium label.
Added Priority-High label.

@DartBot
Copy link

DartBot commented Dec 8, 2012

This comment was originally written by @aam

Is this still a problem? In r15872, I removed arithmetic_test from language_dart2js.status file and was able to run the test fine on mac:
===
macpro:dart aam$ tools/test.py -mrelease -cdart2js -rsafari language/arithmetic_test
Test configuration: dart2js_safari_release_ia32
[00:04 | 100% | + 1 | - 0]
===

@DartBot
Copy link

DartBot commented Dec 10, 2012

This comment was originally written by ngeoffray@google.com

The test started failing because it got updated: see https://codereview.chromium.org/11488004/. I'm fixing it to make it pass on dart2js but I haven't tested on macos yet. Once the CL is landed, could you take a second look?

@DartBot
Copy link

DartBot commented Dec 12, 2012

This comment was originally written by ngeoffray@google.com

Removed this from the M2 milestone.
Added this to the M3 milestone.

@DartBot
Copy link

DartBot commented Dec 12, 2012

This comment was originally written by @aam

Hi, Nicholas,

  sorry, forgot to follow up on this.
  Just checked r16039 - language/arithmetic_test still works fine under dart2js/safari.
  I commented "skip test" line in tests/language/language_dart2js.status

[ $compiler == dart2js && $runtime == safari ]
...
#arithmetic_test: Skip # BUG(3492): Times out.

  and was able to run the test fine:

macpro:dart aam$ tools/test.py -mrelease -cdart2js -rsafari -v language/arithmetic_test
Test configuration: dart2js_safari_release_ia32

  1. sdk/bin/dart2js --package-root=xcodebuild/ReleaseIA32/packages/ --out=/Users/aam/Documents/g/dart/dart-repo/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-safari/tests_language_arithmetic_test/test.js /Users/aam/Documents/g/dart/dart-repo/dart/tests/language/arithmetic_test.dart
  2. python /Users/aam/Documents/g/dart/dart-repo/dart/tools/testing/run_selenium.py --browser=safari --timeout=478 --out="file:///Users/aam/Documents/g/dart/dart-repo/dart/xcodebuild/ReleaseIA32/generated_tests/dart2js-safari/tests_language_arithmetic_test/../_Users_aam_Documents_g_dart_dart-repo_dart_tests_language_arithmetic_test.dartdart2js-safari.html"
    Starting dart2js-safari release_ia32 language/arithmetic_test...
    ...
    Done dart2js-safari release_ia32 language/arithmetic_test: pass

===
=== All tests succeeded
===

  So I'm still not sure whether this "language/arithmetic_test times out on safari" issue is still outstanding.
  Are we talking about the same thing here?

@DartBot
Copy link

DartBot commented Dec 19, 2012

This comment was originally written by ngeoffray@google.com

Bots cycle green with the test not marked as skip. Making this bug as fixed.

Added Fixed label.

@kasperl kasperl added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Dec 19, 2012
@kasperl kasperl added this to the M3 milestone Dec 19, 2012
copybara-service bot pushed a commit that referenced this issue Sep 5, 2023
@devoncarew
[deps] rev args, bazel_worker, benchmark_harness, characters, collect…
032c2d7 
…ion, dartdoc, ecosystem, file, glob, html, http_multi_server, http_parser, json_rpc_2, mockito, package_config, protobuf, pub_semver, source_maps, source_span, sync_http, test_reflective_loader, usage, vector_math, web_socket_channel, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/da56b18..5a4e16f):
  5a4e16f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#254)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/f950bbf..159e671):
  159e671  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#80)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/fde73cb..7d0d28e):
  7d0d28e  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#92)

characters (https://github.com/dart-lang/characters/compare/ec844db..7633a16):
  7633a16  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#86)

collection (https://github.com/dart-lang/collection/compare/1a9b7eb..91afde4):
  91afde4  2023-09-02  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#311)

dartdoc (https://github.com/dart-lang/dartdoc/compare/695b218..a32ba3a):
  a32ba3a1  2023-09-05  Parker Lougheed  Enable accidentally disabled reflective parameter test (#3490)
  0c0cb4ed  2023-09-04  dependabot[bot]  Bump actions/checkout from 3.5.3 to 4.0.0 (#3492)
  08d8d9c4  2023-09-01  Sam Rawlins  Implement much support for extension types (#3489)

ecosystem (https://github.com/dart-lang/ecosystem/compare/89e58de..2e6c3ec):
  2e6c3ec  2023-09-05  Hossein Yousefi  Fix Publish Workflow (#162)
  2e532e3  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#161)

file (https://github.com/google/file.dart/compare/5d9a602..a18ad1c):
  a18ad1c  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.6.0 (#228)

glob (https://github.com/dart-lang/glob/compare/5b24393..9c1996f):
  9c1996f  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#82)

html (https://github.com/dart-lang/html/compare/4060496..a1b193e):
  a1b193e  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#225)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/aa128cf..9d62ea3):
  9d62ea3  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#57)

http_parser (https://github.com/dart-lang/http_parser/compare/c14fbf6..d2d03e7):
  d2d03e7  2023-09-02  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#77)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/509f71e..50a3786):
  50a3786  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#101)

mockito (https://github.com/dart-lang/mockito/compare/f5abf11..412c0be):
  412c0be  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#692)

package_config (https://github.com/dart-lang/package_config/compare/981c49d..ae7ad83):
  ae7ad83  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#140)

protobuf (https://github.com/dart-lang/protobuf/compare/5e8f36b..c16bc89):
  c16bc89  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.6.0 (#873)

pub_semver (https://github.com/dart-lang/pub_semver/compare/028b435..f0be74a):
  f0be74a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#91)

source_maps (https://github.com/dart-lang/source_maps/compare/97c4833..eb3d40a):
  eb3d40a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#81)

source_span (https://github.com/dart-lang/source_span/compare/37735ae..48d0f57):
  48d0f57  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#101)

sync_http (https://github.com/dart-lang/sync_http/compare/c3d6ad4..8233f74):
  8233f74  2023-09-01  Devon Carew  Merge pull request #37 from google/dependabot/github_actions/actions/checkout-3.6.0
  57dc02b  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.6.0

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/0bfaad9..45c57d6):
  45c57d6  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#51)

usage (https://github.com/dart-lang/usage/compare/09bb847..7b12d51):
  7b12d51  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#197)

vector_math (https://github.com/google/vector_math.dart/compare/88bada3..d54af8a):
  d54af8a  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.6.0 (#301)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/4d1b543..af945f1):
  af945f1  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.3 to 3.6.0 (#283)

webdriver (https://github.com/google/webdriver.dart/compare/20ec47f..21976d6):
  21976d6  2023-09-01  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.6.0 (#279)
  352b9b6  2023-09-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 1.1.0 to 2.2.0 (#278)

Change-Id: I0b1f7a8851a7ee992d5b67a221ab523f55b51240
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324261
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Milestone
M3
Development

No branches or pull requests
4 participants
@rakudrama @kasperl @peter-ahe-google @DartBot