Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Benchmark smoke test fails on IE #3403

Closed
kasperl opened this issue Jun 6, 2012 · 7 comments
Closed

Benchmark smoke test fails on IE #3403

kasperl opened this issue Jun 6, 2012 · 7 comments
Assignees
@kasperl
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js

Comments

@kasperl
Copy link

kasperl commented Jun 6, 2012

After r8332.
@efortuna
Copy link
Contributor

efortuna commented Jun 6, 2012

We cannot run any browser performance tests in IE when this is broken. I hope we can fix this ASAP.

@rakudrama
Copy link
Member

I added a comment to https://chromiumcodereview.appspot.com//10544026 (r8332).

Basically: use getTypeNameOf only as a last resort, and if that does not work, use the string 'unknown'.

@kasperl
Copy link
Author

kasperl commented Jun 7, 2012

Set owner to @kasperl.
Added Accepted label.

@kasperl
Copy link
Author

kasperl commented Jun 8, 2012

I'm having a hard time reproducing this locally.

@efortuna
Copy link
Contributor

I'm able to reproduce it okay on my machine. I ran
tools/test.py -m release -c dart2js -r ie benchmark_smoke and got the following output:

Test configuration: dart2js_ie_release_ia32
[00:00 | --% | + 0 | - 0]
FAILED: dart2js-ie release_ia32 benchmark_smoke/benchmark_smoke_test
Expected: pass
Actual: fail

stdout:
<table class="unittest-table"><tbody><tr><td class="unittest-fail" colSpan="3">FAIL</td></tr> <
tr>
        <td>1</td>
        <td class="unittest-error">ERROR</td>
        <td>Expectation: performanceTesting. Caught Instance of 'Error'</td>
      </tr><tr><td></td><td colSpan="2"><pre></pre></td></tr> <tr><td colSpan="3">Total
            <span class="unittest-pass">0 passed</span>,
            <span class="unittest-fail">0 failed</span>
            <span class="unittest-error">
            1 errors</span>
          </td></tr></tbody></table></body></html

Compilation command: ReleaseIA32/dart2js.bat --verbose --out=C:/Users/efortuna/dart/ReleaseIA32/gene
rated_tests/dart2js-ie/tests_benchmark_smoke_benchmark_smoke_test/test.js C:/Users/efortuna/dart/tes
ts/benchmark_smoke/benchmark_smoke_test.dart

Command line: python C:/Users/efortuna/dart/tools/testing/run_selenium.py --browser=ie --timeout=238
 --out=C:/Users/efortuna/dart/ReleaseIA32/generated_tests/dart2js-ie/tests_benchmark_smoke_benchmark
_smoke_test/../C__Users_efortuna_dart_tests_benchmark_smoke_benchmark_smoke_test.dartdart2js-ie.html

[00:07 | 100% | + 0 | - 1]

FAILED: dart2js-ie release_ia32 benchmark_smoke/benchmark_smoke_test
Expected: pass
Actual: fail

stdout:
<table class="unittest-table"><tbody><tr><td class="unittest-fail" colSpan="3">FAIL</td></tr> <
tr>
        <td>1</td>
        <td class="unittest-error">ERROR</td>
        <td>Expectation: performanceTesting. Caught Instance of 'Error'</td>
      </tr><tr><td></td><td colSpan="2"><pre></pre></td></tr> <tr><td colSpan="3">Total
            <span class="unittest-pass">0 passed</span>,
            <span class="unittest-fail">0 failed</span>
            <span class="unittest-error">
            1 errors</span>
          </td></tr></tbody></table></body></html

Compilation command: ReleaseIA32/dart2js.bat --verbose --out=C:/Users/efortuna/dart/ReleaseIA32/gene
rated_tests/dart2js-ie/tests_benchmark_smoke_benchmark_smoke_test/test.js C:/Users/efortuna/dart/tes
ts/benchmark_smoke/benchmark_smoke_test.dart

Command line: python C:/Users/efortuna/dart/tools/testing/run_selenium.py --browser=ie --timeout=238
 --out=C:/Users/efortuna/dart/ReleaseIA32/generated_tests/dart2js-ie/tests_benchmark_smoke_benchmark
_smoke_test/../C__Users_efortuna_dart_tests_benchmark_smoke_benchmark_smoke_test.dartdart2js-ie.html

[00:07 | 100% | + 0 | - 1]

Let me know if I can provide more help for you to set this up locally to reproduce.

@kasperl
Copy link
Author

kasperl commented Jul 2, 2012

I will take another look. Thanks, Emily!

@kasperl
Copy link
Author

kasperl commented Jul 5, 2012

Fixed in r9417.

Added Fixed label.

@kasperl kasperl added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Jul 5, 2012
@kasperl kasperl self-assigned this Jul 5, 2012
copybara-service bot pushed a commit that referenced this issue May 16, 2023
@devoncarew
[deps] rev args, async, bazel_worker, benchmark_harness, boolean_sele…
94c2f65 
…ctor, browser_launcher, characters, cli_util, clock, collection, crypto, dartdoc, leak_tracker, lints

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2):
  f0f6cd2  2023-05-12  Devon Carew  blast_repo fixes (#243)

async (https://github.com/dart-lang/async/compare/0f368d3..d744058):
  d744058  2023-05-12  Devon Carew  blast_repo fixes (#242)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f):
  d9b389f  2023-05-12  Devon Carew  blast_repo fixes (#73)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4):
  e717ad4  2023-05-12  Devon Carew  blast_repo fixes (#90)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..3a1c982):
  3a1c982  2023-05-15  Devon Carew  Update README.md (#48)
  23e08e0  2023-05-12  Devon Carew  blast_repo fixes (#47)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315):
  40e4315  2023-05-12  Devon Carew  blast_repo fixes (#45)

characters (https://github.com/dart-lang/characters/compare/2af6783..3ef8883):
  3ef8883  2023-05-15  Devon Carew  blast_repo fixes (#82)

cli_util (https://github.com/dart-lang/cli_util/compare/7234f17..5a49947):
  5a49947  2023-05-15  Devon Carew  blast_repo fixes (#83)

clock (https://github.com/dart-lang/clock/compare/6b9df3e..fe85908):
  fe85908  2023-05-15  Devon Carew  blast_repo fixes (#51)

collection (https://github.com/dart-lang/collection/compare/6abff47..db2da48):
  db2da48  2023-05-15  Devon Carew  blast_repo fixes (#288)

crypto (https://github.com/dart-lang/crypto/compare/4e9dde1..216931a):
  216931a  2023-05-15  Devon Carew  blast_repo fixes (#149)

dartdoc (https://github.com/dart-lang/dartdoc/compare/d01ddc5..2952f6b):
  2952f6bf  2023-05-16  Sam Rawlins  Simplify ToolConfiguration and other options code (#3414)
  0cf21c15  2023-05-12  Janice Collins  Extract fileName / fileType from ModelElement, LibraryContainer into FileStructure (#3413)
  2ae78bcc  2023-05-12  Sam Rawlins  Split sidebars out into separate HTML files (#3384)
  f00d0443  2023-05-11  Janice Collins  Housekeeping:  language version 3.0, analyzer deprecations, pubspec update (#3412)
  370477d2  2023-05-10  dependabot[bot]  Bump github/codeql-action from 2.3.2 to 2.3.3 (#3410)
  e8c5de44  2023-05-08  Janice Collins  Begin extracting file structure information from ModelElement (#3408)
  24af8a11  2023-05-04  Janice Collins  Add a hideConstantImplementations dartdoc directive (#3398)
  078d42fd  2023-05-03  Janice Collins  Change language feature wording based on review in #3401 (#3405)
  31088c1b  2023-05-03  dependabot[bot]  Bump github/codeql-action from 2.2.12 to 2.3.2 (#3403)
  60055b4e  2023-05-03  Sam Rawlins  Update validate-sdk-docs task to allow 20 libs (#3404)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/bc7f604..8ae200a):
  8ae200a  2023-05-15  Polina Cherkasova  - (#62)

lints (https://github.com/dart-lang/lints/compare/17276ec..72f107a):
  72f107a  2023-05-15  Devon Carew  blast_repo fixes (#120)
  6732fbc  2023-05-15  Devon Carew  blast_repo fixes (#119)

Change-Id: Ibbb1fcc530da01653fe325bdcf77f1c764887a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303783
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kasperl kasperl

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakudrama @efortuna @kasperl