Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

dartc fails ImplicitThisTest/none #375

Closed
peter-ahe-google opened this issue Nov 8, 2011 · 4 comments
Closed

dartc fails ImplicitThisTest/none #375

peter-ahe-google opened this issue Nov 8, 2011 · 4 comments
Assignees
@scheglov

Comments

@peter-ahe-google
Copy link
Contributor

This is a pretty nasty test that also uses the abstract keyword on classes. This is in the spec but as far as I know not yet implemented by any Dart VM or compiler.

ImplicitThisTest/none: Fail

Please notice that the current implementation for detecting abstract classes in dartc is wrong, this is because the specification has changed since I implemented it in dartc. Fortunately, it is much simpler now.

I have an old patch to dartc that I never submitted for detecting unimplemented getters and setters. Let me know if there is interest in looking at this patch and I can upload it to the code review server.
@DartBot
Copy link

DartBot commented Nov 28, 2011

This comment was originally written by zundel@google.com

http://codereview.chromium.org/8728001/

Set owner to @scheglov.

@DartBot
Copy link

DartBot commented Nov 28, 2011

This comment was originally written by zundel@google.com

We are making changes to the compiler and following some of the notes in the non-normative text in section 7.1.1. There must be some reason it hasn't firmed up by now - please let us know if this change is premature.

cc @gbracha.

@scheglov
Copy link
Contributor

Issue #362 has been merged into this issue.

@scheglov
Copy link
Contributor

scheglov commented Dec 7, 2011

Now we produce all warnings, recommended by spec for abstract/incomplete classes.

Added Fixed label.

dart-bot pushed a commit that referenced this issue Jun 12, 2019
@athomas
[co19] Roll co19 to cd1be9d07df32413024fe5c4ae9c5c6017c2f2c8
299532d 
2019-06-11 tvolkert@users.noreply.github.com More fixes to cast response to Stream<List<int>> (#385)
2019-06-11 tvolkert@users.noreply.github.com Pass Uint8List to Datagram (#382)
2019-06-11 tvolkert@users.noreply.github.com Cast HttpRequest and HttpClientResponse streams to List<int> (#384)
2019-06-10 sgrekhov@unipro.ru Fixes #364. Change expected result to null for default values of clientMaxWindowBits and serverMaxWindowBits
2019-06-07 sgrekhov@unipro.ru Fixes #380. Added tests for logical and bitwise operations via type aliases
2019-06-07 sgrekhov@unipro.ru Additional fix for #373. Code style improved and more strict pattern checking
2019-06-06 sgrekhov@unipro.ru Fix for #380. Added tests for type aliases for built-in types. Test string concatenation and arithmetic operations
2019-06-05 sgrekhov@unipro.ru Fixes #380. Added tests for type aliases for built-in types initialization
2019-06-05 sgrekhov@unipro.ru Fixes #373. Expect reasonable file mode on Unix
2019-06-04 sgrekhov@unipro.ru Fixes #379. Numerous fixes for io/Process tests
2019-06-04 sgrekhov@unipro.ru Fixes #378. Use Platform.resolvedExecutable instead of 'dart' command
2019-06-04 irina.arkhipets@gmail.com Fixed Issue #375: it's possible that IPv6 loopback does not exist.
2019-06-04 irina.arkhipets@gmail.com Fixed Issue #236: host.host can be either "localhost" or Platform.localHostname.
2019-06-04 irina.arkhipets@gmail.com Issue #370, instantiate-to-bounds: added static tests for non-function type aliases.
2019-06-04 sgrekhov@unipro.ru Fix for #377. Use correct network interface type name (IPvX)
2019-06-04 sgrekhov@unipro.ru Fixes #374. Change pattern for error messages
2019-06-04 irina.arkhipets@gmail.com Issue #370, instantiate-to-bounds: added dynamic tests for non-function type aliases.
2019-06-04 sgrekhov@unipro.ru Fix for #372. Expect.fail() on timeout added
2019-06-04 sgrekhov@unipro.ru Fixes #371. Remove excessive asyncStart()
2019-06-03 irina.arkhipets@gmail.com Issue #147, test super bounded types: added tests for non-function type aliases.
2019-05-30 sgrekhov@unipro.ru Fixes #369. Use correct type arguments to avoid errors
2019-05-30 sgrekhov@unipro.ru Fixes #368. Don't try to bind system port
2019-05-30 sgrekhov@unipro.ru Fixes #367. Remove excessive asyncStart()
2019-05-30 sgrekhov@unipro.ru Fixes #366. Change expected result to SocketException

TBR=whesse@google.com

Change-Id: I137689755907b3333e597d7d210db2b4d37d70d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105641
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
@mmukagali mmukagali mentioned this issue Dec 2, 2022
Closed
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@scheglov scheglov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scheglov @peter-ahe-google @DartBot