Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ouline View thinks getters are setters #378

Closed
stevemessick opened this issue Nov 8, 2011 · 2 comments
Closed

Ouline View thinks getters are setters #378

stevemessick opened this issue Nov 8, 2011 · 2 comments
Assignees
@keertip

Comments

@stevemessick
Copy link
Contributor

Open dart:html Document. In the Outline View select a getter, like elements. The setter is highlighted in the source. Also, the same icon is used for both getters and setters; since the names are the same there should be some visible indication that one is a getter and one is a setter.
@keertip
Copy link
Contributor

keertip commented Nov 8, 2011

Set owner to @keertip.
Added Started label.

@keertip
Copy link
Contributor

keertip commented Nov 9, 2011

Added Fixed label.

nex3 pushed a commit that referenced this issue Aug 31, 2016
@vsmenon
Fixes #378
a6f4d9b 
Handles fields on "extension" types

See patch #1 for the test without the fix.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1492523004 .
dart-bot pushed a commit that referenced this issue Jun 12, 2019
@athomas
[co19] Roll co19 to cd1be9d07df32413024fe5c4ae9c5c6017c2f2c8
299532d 
2019-06-11 tvolkert@users.noreply.github.com More fixes to cast response to Stream<List<int>> (#385)
2019-06-11 tvolkert@users.noreply.github.com Pass Uint8List to Datagram (#382)
2019-06-11 tvolkert@users.noreply.github.com Cast HttpRequest and HttpClientResponse streams to List<int> (#384)
2019-06-10 sgrekhov@unipro.ru Fixes #364. Change expected result to null for default values of clientMaxWindowBits and serverMaxWindowBits
2019-06-07 sgrekhov@unipro.ru Fixes #380. Added tests for logical and bitwise operations via type aliases
2019-06-07 sgrekhov@unipro.ru Additional fix for #373. Code style improved and more strict pattern checking
2019-06-06 sgrekhov@unipro.ru Fix for #380. Added tests for type aliases for built-in types. Test string concatenation and arithmetic operations
2019-06-05 sgrekhov@unipro.ru Fixes #380. Added tests for type aliases for built-in types initialization
2019-06-05 sgrekhov@unipro.ru Fixes #373. Expect reasonable file mode on Unix
2019-06-04 sgrekhov@unipro.ru Fixes #379. Numerous fixes for io/Process tests
2019-06-04 sgrekhov@unipro.ru Fixes #378. Use Platform.resolvedExecutable instead of 'dart' command
2019-06-04 irina.arkhipets@gmail.com Fixed Issue #375: it's possible that IPv6 loopback does not exist.
2019-06-04 irina.arkhipets@gmail.com Fixed Issue #236: host.host can be either "localhost" or Platform.localHostname.
2019-06-04 irina.arkhipets@gmail.com Issue #370, instantiate-to-bounds: added static tests for non-function type aliases.
2019-06-04 sgrekhov@unipro.ru Fix for #377. Use correct network interface type name (IPvX)
2019-06-04 sgrekhov@unipro.ru Fixes #374. Change pattern for error messages
2019-06-04 irina.arkhipets@gmail.com Issue #370, instantiate-to-bounds: added dynamic tests for non-function type aliases.
2019-06-04 sgrekhov@unipro.ru Fix for #372. Expect.fail() on timeout added
2019-06-04 sgrekhov@unipro.ru Fixes #371. Remove excessive asyncStart()
2019-06-03 irina.arkhipets@gmail.com Issue #147, test super bounded types: added tests for non-function type aliases.
2019-05-30 sgrekhov@unipro.ru Fixes #369. Use correct type arguments to avoid errors
2019-05-30 sgrekhov@unipro.ru Fixes #368. Don't try to bind system port
2019-05-30 sgrekhov@unipro.ru Fixes #367. Remove excessive asyncStart()
2019-05-30 sgrekhov@unipro.ru Fixes #366. Change expected result to SocketException

TBR=whesse@google.com

Change-Id: I137689755907b3333e597d7d210db2b4d37d70d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105641
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue Sep 14, 2023
@devoncarew
[deps] rev ecosystem, http, native, shelf, tools, webdev
9de782c 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/e96fbdb..babf5d1):
  babf5d1  2023-09-13  Devon Carew  add additional lints to dart_flutter_team_lints (#167)
  7740bef  2023-09-13  Moritz  Write comments on forks for `firehose` (#165)

http (https://github.com/dart-lang/http/compare/de19214..e19094a):
  e19094a  2023-09-14  Brian Quinlan  Use efficient operations when copying bytes between Dart and Java (#1019)
  d7e4375  2023-09-13  Parker Lougheed  Cleanup `package:http` utils (#1011)
  eafbbb0  2023-09-12  Brian Quinlan  Separate the cronet callbacks from the `send` method (#1017)
  2cbb703  2023-09-12  Brian Quinlan  Switch `cronet_http` to use jnigen (#1016)

native (https://github.com/dart-lang/native/compare/bbcbc1f..7faf62c):
  7faf62c  2023-09-14  Gabriel Terwesten  Add `includes`, `flags`, `std`, `language`, `cppLinkStdLib` options (#125)

shelf (https://github.com/dart-lang/shelf/compare/2926f76..e2a02b7):
  e2a02b7  2023-09-13  Kevin Moore  Move to latest pkg:dart_flutter_team_lints, bump min sdk to Dart 3 (#378)

tools (https://github.com/dart-lang/tools/compare/fa01f9b..1512f3d):
  1512f3d  2023-09-13  Elias Yishak  Add Fake Analytics instance that uses list to save events sent (#149)

webdev (https://github.com/dart-lang/webdev/compare/6b21ecf..501ccc2):
  501ccc28  2023-09-12  Elliott Brooks  Update DCM triggers to match Dart DevTools (#2230)

Change-Id: Ic3dc1924da48454a28e4c0d8705244ac1565e74a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325967
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@keertip keertip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keertip @stevemessick