Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

double toString precision #452

Closed
DartBot opened this issue Nov 15, 2011 · 7 comments
Closed

double toString precision #452

DartBot opened this issue Nov 15, 2011 · 7 comments
Assignees
@floitschG
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@DartBot
Copy link

DartBot commented Nov 15, 2011

This issue was originally filed by kresten.kr...@gmail.com

DartVM prints doubles with 6 digits after the period, dartc prints it with 12 digits.
@floitschG
Copy link
Contributor

Added Area-VM, Triaged labels.

@ghost
Copy link

ghost commented Nov 15, 2011

Assigning to you since it is your code that needs to be moved into VM. How soon can you do it?

Set owner to @floitschG.

@floitschG
Copy link
Contributor

Afaik Ivan wants the code to be copied into the project. Where should I put it (what directory)?
Are you fine with your input-direction (strtod) or should this one be replaced too?

@iposva-google
Copy link
Contributor

Florian, which files are we talking about?

cc @sgmitrovic.
Added Accepted label.

@floitschG
Copy link
Contributor

I would take all files in
http://code.google.com/p/double-conversion/source/browse/#hg%2Fsrc

@iposva-google
Copy link
Contributor

Please put the necessary files into runtime/third_party/double_conversion.

@floitschG
Copy link
Contributor

This has been fixed a long time ago.

Added Fixed label.

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Jun 18, 2012
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue Oct 26, 2022
@devoncarew
[deps] rev markdown, source_span, string_scanner
3eecfa2 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

markdown (https://github.com/dart-lang/markdown/compare/93d0eee..9b61871):
  9b61871  2022-10-25  Kevin Moore  Make helper class private that should not have been exposed (#476)
  299964e  2022-10-26  le.chang  Return list for link nodes creation (#452)
  aee6a40  2022-10-25  Kevin Moore  validate code coverage on CI (#474)
  88f3f8a  2022-10-25  Zhiguang Chen  Fix html entity and numeric character references (#467)

source_span (https://github.com/dart-lang/source_span/compare/ff03af1..d1d47e5):
  d1d47e5  2022-10-25  Kevin Moore  Require Dart 2.18, update lints, latest pkg:lints, add dependabot (#88)

string_scanner (https://github.com/dart-lang/string_scanner/compare/2d84b16..10435a4):
  10435a4  2022-10-25  Kevin Moore  Update minimum SDK, latest pkg:lints, update CI actions (#48)

Change-Id: I94dbb0830600cb5304aaae16b2ae715bfc71411e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265641
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 31, 2022
@devoncarew
Bump markdown to 49eefd211e7840bac7e11257cd966435ae3cb07f
2f072c8 
Changes:
```
> git log --format="%C(auto) %h %s" 93d0eee..49eefd2
 https://dart.googlesource.com/markdown.git/+/49eefd2 Refactor AutolinkExtensionSyntax (#471)
 https://dart.googlesource.com/markdown.git/+/07e2683 Optimise TableSyntax (#472)
 https://dart.googlesource.com/markdown.git/+/9b61871 Make helper class private that should not have been exposed (#476)
 https://dart.googlesource.com/markdown.git/+/299964e Return list for link nodes creation (#452)
 https://dart.googlesource.com/markdown.git/+/aee6a40 validate code coverage on CI (#474)
 https://dart.googlesource.com/markdown.git/+/88f3f8a Fix html entity and numeric character references (#467)

```

Diff: https://dart.googlesource.com/markdown.git/+/93d0eee771f6355be6737c2a865f613f6b105bf1~..49eefd211e7840bac7e11257cd966435ae3cb07f/
Change-Id: I2a88d7c386f567738226701be4edcd7c4818744f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266760
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
Reviewed-by: Oleh Prypin <oprypin@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@floitschG floitschG

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iposva-google @floitschG @DartBot