Skip to content

Expect.listEquals produces incorrect message #476

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
DartBot opened this issue Nov 16, 2011 · 2 comments
Closed

Expect.listEquals produces incorrect message #476

DartBot opened this issue Nov 16, 2011 · 2 comments
Assignees

Comments

@DartBot
Copy link

DartBot commented Nov 16, 2011

This issue was originally filed by rodion...@unipro.ru


Affected tests:

  1. LibTest/core/Expect/listEquals/Expect/listEquals/A03/t01

Details: (please list relevant API changes or quote specification)

For the following arguments: [1, 5, 3], [1, 10, 3]
this method produces an incorrect message:
"Expect.listEquals(at index 1, expected: <1>, actual: <10>) fails"

What version of the product are you using? On what operating system?
rev. 1562, ubuntu 10 x64

@madsager
Copy link
Contributor

Easy fix. I'll take this one.


Set owner to @madsager.
Added Accepted label.

@madsager
Copy link
Contributor

Added Fixed label.

copybara-service bot pushed a commit that referenced this issue Oct 26, 2022
Revisions updated by `dart tools/rev_sdk_deps.dart`.

markdown (https://github.com/dart-lang/markdown/compare/93d0eee..9b61871):
  9b61871  2022-10-25  Kevin Moore  Make helper class private that should not have been exposed (#476)
  299964e  2022-10-26  le.chang  Return list for link nodes creation (#452)
  aee6a40  2022-10-25  Kevin Moore  validate code coverage on CI (#474)
  88f3f8a  2022-10-25  Zhiguang Chen  Fix html entity and numeric character references (#467)

source_span (https://github.com/dart-lang/source_span/compare/ff03af1..d1d47e5):
  d1d47e5  2022-10-25  Kevin Moore  Require Dart 2.18, update lints, latest pkg:lints, add dependabot (#88)

string_scanner (https://github.com/dart-lang/string_scanner/compare/2d84b16..10435a4):
  10435a4  2022-10-25  Kevin Moore  Update minimum SDK, latest pkg:lints, update CI actions (#48)

Change-Id: I94dbb0830600cb5304aaae16b2ae715bfc71411e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265641
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 31, 2022
Changes:
```
> git log --format="%C(auto) %h %s" 93d0eee..49eefd2
 https://dart.googlesource.com/markdown.git/+/49eefd2 Refactor AutolinkExtensionSyntax (#471)
 https://dart.googlesource.com/markdown.git/+/07e2683 Optimise TableSyntax (#472)
 https://dart.googlesource.com/markdown.git/+/9b61871 Make helper class private that should not have been exposed (#476)
 https://dart.googlesource.com/markdown.git/+/299964e Return list for link nodes creation (#452)
 https://dart.googlesource.com/markdown.git/+/aee6a40 validate code coverage on CI (#474)
 https://dart.googlesource.com/markdown.git/+/88f3f8a Fix html entity and numeric character references (#467)

```

Diff: https://dart.googlesource.com/markdown.git/+/93d0eee771f6355be6737c2a865f613f6b105bf1~..49eefd211e7840bac7e11257cd966435ae3cb07f/
Change-Id: I2a88d7c386f567738226701be4edcd7c4818744f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266760
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
Reviewed-by: Oleh Prypin <oprypin@google.com>
@pq pq mentioned this issue Nov 18, 2024
11 tasks
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants