-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[deps] switch to comfy-table from prettytable #1126
Conversation
Signed-off-by: Chojan Shang <psiace@outlook.com>
Thanks for the contribution! Please review the labels and make any necessary changes. |
Hello @PsiACE, 🎉 Thank you for opening the pull request! 🎉 |
@@ -18,4 +18,4 @@ common-infallible = {path = "../infallible"} | |||
|
|||
# Crates.io dependencies | |||
ahash = "0.7.4" | |||
prettytable-rs = { version = "0.8.0"} | |||
comfy-table = "4.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @PsiACE
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
=========================================
+ Coverage 52% 68% +16%
=========================================
Files 108 434 +326
Lines 7306 24692 +17386
=========================================
+ Hits 3847 17006 +13159
- Misses 3459 7686 +4227
Continue to review full report at Codecov.
|
CI Passed |
Signed-off-by: Chojan Shang psiace@outlook.com
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
Switch to comfy-table from prettytable. In addition, comfy-table is still actively maintained.
Changelog
Related Issues
Fixes #1095
Test Plan
Unit Tests
Stateless Tests