-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[deps] all in comfy-table #1323
Conversation
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Thanks for the contribution! Please review the labels and make any necessary changes. |
Hello @PsiACE, 🎉 Thank you for opening the pull request! 🎉 |
Signed-off-by: Chojan Shang <psiace@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
======================================
Coverage 72% 72%
======================================
Files 481 481
Lines 27975 27967 -8
======================================
Hits 20252 20252
+ Misses 7723 7715 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @PsiACE
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
remove prettytable-rs, all in comfy-table
☑
, this will make the comfy-table align correctlyChangelog
Related Issues
Related #1126 #1095 jorgecarleitao/arrow2#251
Test Plan
Unit Tests
Stateless Tests