-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reproducible path to "triangles frozen" problem. See https://github.com/Day8/re-frame-10x#the-expansion-triangles-in-the-data-browsers-dont-work-any-more-but-they-used-to #209
Comments
I think I found a path that reproduces the bug.
Startup error (with some earlier lines, for context):
|
Thanks for this, can you give a bit more info on your setup? What OS/Browser are you using? |
Ubuntu 16.04. Chrome Version 67.0.3396.18 (Official Build) beta (64-bit). |
In my list of steps above, killing the app does not seem to be needed. It is, at least sometimes, enough to just refresh the app. Possibly only when the 10x window is external but hidden under another window. |
I can replicate the issue simply by refreshing the page while 10x is open in an external window. |
Had this issue out of nowhere as well across a chrome 66 version and after upgrading to the latest Version 67.0.3396.99 (Official Build) (64-bit). Settings -> Factory reset seems to have fixed it completely. |
Any progress on this? Anything I can do to help (at the level of gathering evidence)? Still happening to me repeatably, just by refreshing the page while 10x open in external window, |
Same behavior here. Refreshing the page while 10x is popped out will consistently reproduce.
|
One thing that I noticed is that after page refresh and closing the open 10x window, the |
I can also confirm that it is enough to delete the |
I can confirm with Windows 7 and Chrome 68. |
I've had a go at reproducing this against the Todo MVC re-frame sample app, and I'm not able to. Can someone share a reproducible example, ideally against something small? Edit: Just after posting this it happened to me too. |
I have been able to reproduce this, but only sporadically. If anyone can share a codebase that can reliably do this every time that would be helpful. I'm also not seeing the error messages you are @deg. For me it seems to happen if I'm doing something else for a while, and a main window refresh seems to clear it up. The issue looks to be wider than just the triangles being frozen, it seems like no events are firing at all when this issue happens. The external window size being small is happening because the width and height on While I'm interested in solving this issue, I don't have a ton of spare time for it at the moment, so if others are able to help pinpoint the issue, that would be very helpful. |
I have two ideas, which kind of contradict each other... Direction 1: For me, this seems to happen in all my projects, so I've assumed it was environmental, not project-specific. So, I don't believe you'd gain much with a shared codebase. But, in case I'm wrong (and see direction 2 below!), I'd say try any of my projects. The problem is that, I can't think of any which are public, easy to setup, and in which I'm certain I've seen the problem. I'm in a crunch for the next few days, but I'll try to find one for you soon. Direction 2: Maybe the problem is caused by something common to all my current projects. I learned something new a few hours ago. See deg/re-frame-firebase#24. Most of my project use re-frame-firebase which depends on re-frame 0.10.5 and on reagent 0.8.1. They apparently disagree on React 15 vs 16. Maybe these, combined with some injection complexity in re-frame-10x could be somehow messing things up. |
I am able to consistently reproduce using the re-frame template with the following steps:
|
I can confirm @JarrodCTaylor. On one of my projects that fails consistently, I changed
and fixed all my The problem went away! |
Hey folks, thanks for the debugging information here. At this stage, it looks like we are unlikely to have any bandwidth to work on re-frame-10x through to the end of the year. We're happy to take a PR that fixes the issue, but short of that, we don't have much time to go further on this. |
To add more information to the discussion, even though I realize there's limited bandwidth to work on this right now, I've noticed I continue to have trouble when the Chrome pop-up blocker is enabled. The problem is that after you reset profile settings in Chrome the pop-up blocker is enabled so when I open a new session the 10x external window gets blocked and then subsequently fails expanding triangles. If I disable the pop-up blocker I can't reproduce this issue. I think this reinforces some earlier comments regarding the I'm wondering if we should create an installation step to disable the pop-up blocker. |
@mustangJaro the Chrome popup blocker issue should be fixed in https://github.com/Day8/re-frame-10x/releases/tag/0.3.7 (#228). |
The The two key things related to reproducible steps were found to be:
Although the frozen triangles problem may have been infrequently observed after fixing the
Therefore we think its worth closing this issue, and if there are substantial new experiences of a similar or new issue then please raise a new issue to track that accurately. |
No description provided.
The text was updated successfully, but these errors were encountered: