Not handling popup blockers on initial load

[kajism]

If pop-ups are blocked by your browser (Chrome), it can cause confusing exception Uncaught TypeError: Cannot read property 'document' of null followed by stack trace mentioning mranderson. The solution is to always allow pop-ups from your app under development URL (e.g. http://0.0.0.0:3449).

This probably occurs only when the browser was closed previously with separate re-frame-10x debugging window. I have spent a long time to figure out, so I think it should be mentioned in README.md to be easily searchable.

Thanks!

[kajism]

[kajism]

Full stack trace:

Uncaught TypeError: Cannot read property 'document' of null
    at day8$re_frame_10x$events$open_debugger_window (events.js:355)
    at events.js:376
    at mranderson048$re_frame$v0v10v2$re_frame$std_interceptors$fx_handler__GT_interceptor_$_fx_handler_before (std_interceptors.js:126)
    at mranderson048$re_frame$v0v10v2$re_frame$interceptor$invoke_interceptor_fn (interceptor.js:186)
    at mranderson048$re_frame$v0v10v2$re_frame$interceptor$invoke_interceptors (interceptor.js:225)
    at mranderson048$re_frame$v0v10v2$re_frame$interceptor$execute (interceptor.js:335)
    at mranderson048$re_frame$v0v10v2$re_frame$events$handle (events.js:165)
    at Object.mranderson048$re_frame$v0v10v2$re_frame$router$IEventQueue$_process_1st_event_in_queue$arity$1 (router.js:633)
    at mranderson048$re_frame$v0v10v2$re_frame$router$_process_1st_event_in_queue (router.js:116)
    at Object.mranderson048$re_frame$v0v10v2$re_frame$router$IEventQueue$_run_queue$arity$1 (router.js:272)
    at mranderson048$re_frame$v0v10v2$re_frame$router$_run_queue (router.js:154)
    at router.js:527
    at Object.mranderson048$re_frame$v0v10v2$re_frame$router$IEventQueue$_fsm_trigger$arity$3 (router.js:601)
    at mranderson048$re_frame$v0v10v2$re_frame$router$_fsm_trigger (router.js:78)
    at router.js:318

[danielcompton]

Hey, I'd rather fix the error and log a good warning rather than just adding a note in the documentation here.

[kajism]

Good idea, Daniel. So I committed a solution.

[danielcompton]

@kajism I can see where the bug would be, but I'm having trouble reproducing it with Chrome on macOS. I've got Version 71.0.3578.98 (Official Build) (64-bit) on macOS 10.14.2.

Even when I disable popups on the dev site (on localhost and 0.0.0.0), they still pop up. Can you give me some more instructions on how to reproduce this?

In the meantime, I've pushed a fix for this. It shows an error message in the main window instead of logging to the console, as the user may not have their console open and miss the message.

[kajism]

@danielcompton I'm using the same version of Chrome as you e.g. "Version 71.0.3578.98 (Official Build) (64-bit)" on Linux Mint (4.15.0-43-generic #46-Ubuntu SMP Thu Dec 6 14:45:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux).

It can be reproduced this way:

1. open an app using re-frame-10x in Chrome
2. press re-frame-10x "Pop up" button. New window is created and displayed without problem.
3. Close at first the app window than the debugger window
4. repeat step 1 => pop up is blocked, error and stack trace displayed in the console. The funny thing is that when Ctrl-H is pressed now, re-frame-10x is normally displayed and can be even popped out without problem.

Daniel, unfortunately with the current solution committed to master (9462c33), re-frame-10x window is not displayed again and the error stack trace in console is suppressed, so it fails silently. If I don't notice the little "Pop up were blocked on this page" displayed in Chrome, I'm lost completely until I try to press Ctrh-H to see the new error info you have provided.

In addition the error message is displayed in re-frame-10x debugger even when the user don't care to open the separate pop up window.

[danielcompton]

Great, thanks for the details, I can reproduce this now. The issue is only visible when re-frame-10x tries to automatically create a popup on initial page load. I'll fix it in this case too.

[danielcompton]

I think I've cracked it this time, let me know if it's still an issue though. Thanks!

[kajism]

The latest release works nicely. Congratulations and thanks for all your work, Daniel!