Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add tests for cross-database cast macro #173

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Add tests for cross-database cast macro #173

merged 5 commits into from
Apr 19, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Apr 13, 2024

resolves #84
docs: dbt-labs/docs.getdbt.com#5278

Problem

Having a cross-database cast macro has been suggested as a way to address a variety of things including, but not limited to:

Solution

We actually already added it in 5a50be7 within #55 !

But this PR adds some tests (just duplicated from the ones for safe_cast) and a changelog entry.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests
  • This PR has already received feedback and approval from Product or DX

@dbeatty10 dbeatty10 marked this pull request as ready for review April 13, 2024 01:39
@MichelleArk MichelleArk changed the title Cross-database cast macro Add tests for cross-database cast macro Apr 15, 2024
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your choice as to removing the test implementation or keeping it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1229] [Feature] Cross-database cast macro
2 participants