Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Import relevant pytest(s) for cross-database cast macro #77

Merged
merged 4 commits into from
May 14, 2024
Merged

Import relevant pytest(s) for cross-database cast macro #77

merged 4 commits into from
May 14, 2024

Conversation

dbeatty10
Copy link
Contributor

resolves #76

Problem & Solution

dbt-labs/dbt-adapters#173 added testing for the cross-database cast macro, but it is not automatically inherited by each adapter.

Solution

This PR imports and uses that testing.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label May 1, 2024
@VersusFacit VersusFacit self-requested a review May 2, 2024 00:11
VersusFacit
VersusFacit approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests, more coverage, more good times.

@dbeatty10 dbeatty10 mentioned this pull request May 13, 2024
Closed
@dbeatty10 dbeatty10 requested a review from a team as a code owner May 13, 2024 21:03
@dbeatty10 dbeatty10 enabled auto-merge (squash) May 14, 2024 19:01
@dbeatty10 dbeatty10 merged commit 862e8e9 into main May 14, 2024
18 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty/test-cast-macro branch May 14, 2024 19:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import relevant pytest(s) for cross-database cast macro
2 participants
@dbeatty10 @VersusFacit