Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

textFilterWidget should use redrawGroup, not redrawAll #1498

Closed
gordonwoodhull opened this issue Nov 16, 2018 · 1 comment
Closed

textFilterWidget should use redrawGroup, not redrawAll #1498

gordonwoodhull opened this issue Nov 16, 2018 · 1 comment
Labels
bug

Comments

@gordonwoodhull
Copy link
Contributor

Currently when the filter changes, textFilterWidget calls

dc.js/src/text-filter-widget.js

Line 63 in 87cf58e

dc.redrawAll();

This is incorrect because it redraws the default chart group, which might not be the same chart group where this filter resides. Instead it should call chart.redrawGroup() (or supply its own chart group name).
kriddy added a commit to kriddy/dc.js that referenced this issue Apr 10, 2020
@kriddy
Add chartGroup in redrawAll()
eefa222 
It took me some time to figure out why the text filter wasn't working anymore and then I remembered that I recently added groups to the charts. After some google magic I found dc-js#1498 en by changing redrawAll(); to redrawAll(chartGroup); it works again.
@kriddy kriddy mentioned this issue Apr 10, 2020
Closed
@gordonwoodhull
Copy link
Contributor Author

Fixed in version 4.2.1

@gordonwoodhull gordonwoodhull mentioned this issue Feb 8, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gordonwoodhull