Add chartGroup in redrawAll() #1678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me some time to figure out why the text filter wasn't working anymore and then I remembered that I recently added groups to the charts. After some google magic I found dc-js#1498 en by changing redrawAll(); to redrawAll(chartGroup); it works again.
|
Sorry I missed this. Will put in next release. |
|
Looks like this was a combination of dc.js 3.* and 4.* code; I changed it to chart.redrawGroup();and release in version 4.2.1. Thanks @kriddy! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me some time to figure out why the text filter wasn't working anymore and then I remembered that I recently added groups to the charts. After some google magic I found #1498 en by changing redrawAll(); to redrawAll(chartGroup); it works again.