Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: audio issue on first spawn #3438

Merged

Conversation

AlejandroAlvarezMelucciDCL
Copy link
Collaborator

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL commented Feb 25, 2025

Fixes #2038
Fixes #2994

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL added the force-build Used to trigger a build on draft PR label Feb 25, 2025
@Ludmilafantaniella
Copy link

Ludmilafantaniella commented Feb 26, 2025

Hey @AlejandroAlvarezMelucciDCL , I tested the fix by creating a new account and completing the onboarding. The music and all SFX are working correctly during the onboarding.

After jumping into Genesis City from the onboarding, I didn't hear music at first, but after going down the waterfall and coming back, I could hear the waterfall sound. Then, after going down again, I could also hear the radio music.

Additionally, I teleported to Game Expo, and the video sound played correctly. I also tested the Music Festival scene, and the music was working as expected.

Both issues (#2038 and #2994) seem to be fixed! I couldn't approve the PR since it's still a draft, but from my side, it's approved because the most critical functionalities are working properly. 🚀

P.S.: I’ll take care of creating tickets for the issues I noticed in the video.

Explorer.2025-02-26.10-25-05.mp4

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • ✔️ Log In/Log Out
  • ✔️ Backpack and wearables in world
  • ✔️ Emotes in world and in backpack
  • ✔️ Teleport with map/coordinates/Jump In
  • ✔️ Chat and multiplayer
  • ✔️ Profile card
  • ✔️ Camera
  • ✔️ Skybox
  • ✔️ Settings

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL marked this pull request as ready for review February 26, 2025 14:49
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL changed the title Test fixing audio issue on first spawn fix: audio issue on first spawn Feb 26, 2025
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL merged commit fb65ba5 into dev Feb 26, 2025
17 of 18 checks passed
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL deleted the fix/2994-sound-missing-on-first-spawn branch February 26, 2025 17:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
force-build Used to trigger a build on draft PR
Projects
None yet
4 participants