Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: audio issue on first spawn #3438

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: audio issue on first spawn #3438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions Explorer/Assets/DCL/Audio/AudioMixerVolumesController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public class AudioMixerVolumesController
private readonly AudioMixer audioMixer;
private readonly string[] allExposedParams;
private readonly Dictionary<string, float> originalVolumes = new ();
private readonly HashSet<string> mutedGroups = new ();

public AudioMixerVolumesController(AudioMixer audioMixer)
{
Expand All @@ -36,8 +37,14 @@ public void MuteGroup(AudioMixerExposedParam groupParam)
if (exposedParam != groupParamString)
continue;

audioMixer.GetFloat(groupParamString, out float originalVolume);
originalVolumes[groupParamString] = originalVolume;
// Only store the original volume if this group hasn't been muted before
if (!mutedGroups.Contains(groupParamString))
{
audioMixer.GetFloat(groupParamString, out float originalVolume);
originalVolumes[groupParamString] = originalVolume;
mutedGroups.Add(groupParamString);
}

audioMixer.SetFloat(groupParamString, MUTE_VALUE);
break;
}
Expand All @@ -52,7 +59,11 @@ public void UnmuteGroup(AudioMixerExposedParam groupParam)
if (exposedParam != groupParamString)
continue;

audioMixer.SetFloat(groupParamString, originalVolumes[groupParamString]);
if (mutedGroups.Contains(groupParamString))
{
audioMixer.SetFloat(groupParamString, originalVolumes[groupParamString]);
mutedGroups.Remove(groupParamString);
}
break;
}
}
Expand Down
Loading