-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
pi: Make status transition error human readable. #1543
Conversation
This adds human readable billing statuses to the pi plugin and uses them in the invalid billing status transition error.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a unit test veryifying that all statuses have a human readable entry. Format it like this please.
// ErrorCodeLast is used by unit tests to verify that all error codes have
// a human readable entry in the ErrorCodes map. This error will never be
// returned.
ErrorCodeLast ErrorCodeT = 23
err := unittest.TestGenericConstMap(ErrorCodes, uint64(ErrorCodeLast))
if err != nil {
t.Error(err)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
This adds human readable billing statuses to the pi plugin and uses them
in the invalid billing status transition error.
Closes #1541.