Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

computeMatricOperation dataRange #951

Merged
merged 9 commits into from
Jul 23, 2020
Merged

computeMatricOperation dataRange #951

merged 9 commits into from
Jul 23, 2020

Conversation

LeilyR
Copy link
Contributor

@LeilyR LeilyR commented May 20, 2020

Added dataRange to computeMatricOperation to return min,max,median and 10th and 90th percentile.

Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :

  • Does the PR contain new feature?
  • Does the PR contain bugfix?
  • Does the PR contain documentation changes?
  • Does the PR contain changes to the galaxy wrapper?

@LeilyR LeilyR requested a review from dpryan79 May 20, 2020 12:48
@LeilyR
Copy link
Contributor Author

LeilyR commented Jul 9, 2020

Hi @dpryan79, Do you know how I can fix the failing tests? It fails in filtering a BAM file by MAPQ, flag, and blacklist
Also, I cannot figure out what went wrong with the galaxy batch2 tests , I cannot see the build. Can you help me with that too? Thanks!

@LeilyR
Copy link
Contributor Author

LeilyR commented Jul 23, 2020

I will merge this PR despite the failure for galaxy plotPCA, because it has other fixes which helps fixing the test failures of the other hanging PRs. I expect this issue still be available in the other PRs and can be fixed in them.

@LeilyR LeilyR merged commit 80b1d60 into develop Jul 23, 2020
@LeilyR LeilyR deleted the matrix_operation branch July 23, 2020 07:47
LeilyR added a commit that referenced this pull request Aug 21, 2020
* Fixes for 3.4.2

* disable azure on OSX

* Closes #945

* computeMatricOperation  dataRange (#951)

* Added dataRange to computeMatricOperation to return min,max,median and 10th and 90th percentile.

* fixed pep8

* more pep8 fix

* fixed test_sieve of azure tests

* one more fix for test_sieve

* imported pysam to test_readFiltering.py

* updated hash values for test_sieve

* fixed galaxy computeMatrixOperation.xml

* More fixes for galaxy wrapper

* fixed a little typo in bamCompare (#967)

* save the output matrix of the plotheatmap in a format to be compatible with running plotheatmap on it again (#968)

* Plot profile color map (#971)

* Now colors can be set by user for any heatmap in plotProfile. A bug in tick index for plotting heatmap is also fixed.

* added a small description

* pep8 fix

* added sortUsingSamples and clusterUsingSamples to the galaxy wrapper

* [WIP] added auto to plotheatmap #908 (#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

* fix #969 (#970)

* fix #969

* PEP8

* updated changes.txt

* fixed a little bug in parseCommon.py which caused flake8 failure.

* [WIP] added auto to plotheatmap #908 (#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

* updated version and changes

* removed alpha from plotPCA test

* removed compare="sim_size"


* fixed plotHeatmap.xml by removing size from the the params and adding anitizer for the 2 new params.

* upated change.txt

* updated the doc html

Co-authored-by: Devon Ryan <dpryan79@users.noreply.github.com>
blaiseli pushed a commit to blaiseli/deepTools that referenced this pull request Feb 17, 2021
* Fixes for 3.4.2

* disable azure on OSX

* Closes deeptools#945

* computeMatricOperation  dataRange (deeptools#951)

* Added dataRange to computeMatricOperation to return min,max,median and 10th and 90th percentile.

* fixed pep8

* more pep8 fix

* fixed test_sieve of azure tests

* one more fix for test_sieve

* imported pysam to test_readFiltering.py

* updated hash values for test_sieve

* fixed galaxy computeMatrixOperation.xml

* More fixes for galaxy wrapper

* fixed a little typo in bamCompare (deeptools#967)

* save the output matrix of the plotheatmap in a format to be compatible with running plotheatmap on it again (deeptools#968)

* Plot profile color map (deeptools#971)

* Now colors can be set by user for any heatmap in plotProfile. A bug in tick index for plotting heatmap is also fixed.

* added a small description

* pep8 fix

* added sortUsingSamples and clusterUsingSamples to the galaxy wrapper

* [WIP] added auto to plotheatmap deeptools#908 (deeptools#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

* fix deeptools#969 (deeptools#970)

* fix deeptools#969

* PEP8

* updated changes.txt

* fixed a little bug in parseCommon.py which caused flake8 failure.

* [WIP] added auto to plotheatmap deeptools#908 (deeptools#982)

* added auto to plotheatmap

* fixed lint, added warning message, updated the help for zmin, zmax

* galaxy test plotPCA

* lower down the delat for potPCA galaxy test

* updated version and changes

* removed alpha from plotPCA test

* removed compare="sim_size"

* fixed plotHeatmap.xml by removing size from the the params and adding anitizer for the 2 new params.

* upated change.txt

* updated the doc html

Co-authored-by: Devon Ryan <dpryan79@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant