Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(workspace): provide workspace members as 'imports' in import map #23492

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Apr 22, 2024

This commit changes the workspace support to provide all workspace members
to be available as imports based on their names and versions.

Closes #23343

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, tried it out and it works perfectly 👍

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -213,7 +213,7 @@ async function ensureNoNewITests() {
"pm_tests.rs": 0,
"publish_tests.rs": 28,
"repl_tests.rs": 0,
"run_tests.rs": 382,
"run_tests.rs": 379,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bartlomieju bartlomieju merged commit 35220f0 into denoland:main Apr 23, 2024
17 checks passed
@bartlomieju bartlomieju deleted the workspace_import_map_expansion branch April 23, 2024 15:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Workspaces only searches for deno.json instead of also deno.jsonc
3 participants