Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update convert_to_workspace.ts script #4631

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

bartlomieju
Copy link
Member

This bit is not needed anymore since denoland/deno#23492 landed.

@bartlomieju bartlomieju requested a review from kt3k as a code owner April 23, 2024 15:22
@bartlomieju
Copy link
Member Author

This needs to be merged before the next release.

@bartlomieju bartlomieju enabled auto-merge (squash) April 23, 2024 15:23
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (3149cdb) to head (4cfddd0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4631   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         478      478           
  Lines       37383    37383           
  Branches     5308     5308           
=======================================
  Hits        34016    34016           
  Misses       3305     3305           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor

iuioiua commented Apr 23, 2024

Is this right? Dry run is failing.

@bartlomieju
Copy link
Member Author

Is this right? Dry run is failing.

Yeah, probably because it's not yet available on canary. I'll reset CI in couple hours.

@bartlomieju bartlomieju requested a review from iuioiua April 23, 2024 17:45
@bartlomieju bartlomieju merged commit 4a1ed50 into denoland:main Apr 23, 2024
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants