fix(workspace): support resolving bare specifiers to npm pkgs within a workspace #24611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jul 16, 2024
| @@ -1,9 +1,7 @@ | |||
| import * as a1 from "@denotest/a"; | |||
| import * as a2 from "npm:@denotest/a@1"; | |||
| import * as a3 from "npm:@denotest/a@workspace"; | |||
There was a problem hiding this comment.
dsherret
commented
Jul 16, 2024
dsherret
commented
Jul 16, 2024
There was a problem hiding this comment.
The LSP doesn't support npm workspaces yet, so I did not implement this there (I'll add this PR as something to consider for #24505)
bartlomieju
approved these changes
Jul 17, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Jul 22, 2024
…a workspace (#24611) This makes bare specifiers for npm packages work when inside a workspace, which emulates the same behaviour as when there's a node_modules directory. The bare specifier can be overwritten by specifying an import map entry or package.json dependency entry. * denoland/deno_config#88 Closes #24605
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes bare specifiers for npm packages work when inside a workspace, which emulates the same behaviour as when there's a node_modules directory. The bare specifier can be overwritten by specifying an import map entry or package.json dependency entry.
Closes #24605