Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(npm): remove undocumented workspace tag special case #87

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

dsherret
Copy link
Member

This was undocumented. I think we should remove it because it's not super useful and it's yet another complication to resolution. It's also conflating tags to mean something else. We're also going to support bare specifiers for package.json workspace members.

@dsherret dsherret requested a review from bartlomieju July 16, 2024 13:43
@dsherret dsherret changed the title fix: remove undocumented workspace tag special case fix(npm): remove undocumented workspace tag special case Jul 16, 2024
@dsherret dsherret requested a review from lucacasonato July 16, 2024 13:44
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 0970ada into denoland:main Jul 16, 2024
3 checks passed
@dsherret dsherret deleted the fix_remove_workspace_special_case branch July 16, 2024 20:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants