Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: update to deno_config 0.25 #24645

Merged
merged 8 commits into from
Jul 19, 2024
Merged

refactor: update to deno_config 0.25 #24645

merged 8 commits into from
Jul 19, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 19, 2024 •
edited
Loading

  • Gets rid of WorkspaceMemberContext. It's now Workspace and WorkspaceDirectory
  • Uses the workspace cache in the lsp

@dsherret dsherret marked this pull request as draft July 19, 2024 01:54
@dsherret dsherret marked this pull request as ready for review July 19, 2024 16:44
bartlomieju
bartlomieju approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dsherret dsherret merged commit afcae36 into denoland:main Jul 19, 2024
17 checks passed
@dsherret dsherret deleted the refactor_deno_config_workspace_workspace_dir branch July 19, 2024 19:56
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
@dsherret @bartlomieju
refactor: update to deno_config 0.25 (#24645)
3fe388f 
- Gets rid of WorkspaceMemberContext. It's now `Workspace` and
`WorkspaceDirectory`
- Uses the workspace cache in the lsp

* denoland/deno_config#95
* denoland/deno_config#96
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@nayeemrmn nayeemrmn Awaiting requested review from nayeemrmn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju