feat: workspace cache #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jul 18, 2024
| opts.maybe_vendor_override.as_ref(), | ||
| ), | ||
| workspace: new_rc(Workspace::new_single(config_folder)), | ||
| }); |
There was a problem hiding this comment.
This is a bug fix here. Basically, if someone specifies a path like not-deno.json then we shouldn't do workspace discovery because there's no way that this configuration file could be part of the workspace.
Additionally, if someone specifies a deno.jsonc file when there's a deno.json file, the deno.json file would be part of the workspace and not the deno.jsonc, so we should also not do workspace resolution in this case.
dsherret
commented
Jul 18, 2024
src/workspace/mod.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_config_not_deno_workspace_member_non_natural_config_file_name() { |
There was a problem hiding this comment.
dsherret
commented
Jul 18, 2024
| opts.maybe_vendor_override.as_ref(), | ||
| ); | ||
| let mut final_members = BTreeMap::new(); |
There was a problem hiding this comment.
Extracted out to function.
dsherret
commented
Jul 18, 2024
| Some(deno_json.dir_path().join("vendor")) | ||
| } else { | ||
| None | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Changed this to just accept a deno json instead of ConfigFolders, which was needlessly complex
This was referenced Jul 19, 2024
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Jul 19, 2024
- Gets rid of WorkspaceMemberContext. It's now `Workspace` and `WorkspaceDirectory` - Uses the workspace cache in the lsp * denoland/deno_config#95 * denoland/deno_config#96
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Jul 22, 2024
- Gets rid of WorkspaceMemberContext. It's now `Workspace` and `WorkspaceDirectory` - Uses the workspace cache in the lsp * denoland/deno_config#95 * denoland/deno_config#96
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workspace cache for use by the LSP, but also there's a bug fix for another edge case. I'll point out the test and code that fixes the edge case.