Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ext/node): export request and response clases from http2 module #25592

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 12, 2024

Closes #20612
Closes #23326

This makes qwik work.

Screen.Recording.2024-09-12.at.03.28.38.mov

Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 46d5f38 into denoland:main Sep 12, 2024
17 checks passed
@bartlomieju bartlomieju deleted the node_http2_exports branch September 12, 2024 02:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node:http2 doesn't export Http2ServerRequest and Http2ServerResponse Support Qwik City (dev server)
3 participants