Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ext/node): export request and response clases from http2 module #25592

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(ext/node): export request and response clases from http2 module #25592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/node/polyfills/http2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2295,7 +2295,7 @@ function onStreamTimeout(kind) {
};
}

class Http2ServerRequest extends Readable {
export class Http2ServerRequest extends Readable {
readableEnded = false;

constructor(stream, headers, options, rawHeaders) {
Expand Down Expand Up @@ -2523,7 +2523,7 @@ function isConnectionHeaderAllowed(name, value) {
value === "trailers";
}

class Http2ServerResponse extends Stream {
export class Http2ServerResponse extends Stream {
writable = false;
req = null;

Expand Down
5 changes: 5 additions & 0 deletions tests/unit_node/http2_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,3 +378,8 @@ Deno.test("[node/http2 client] connection states", async () => {

assertEquals(actual, expected);
});

Deno.test("request and response exports", () => {
assert(http2.Http2ServerRequest);
assert(http2.Http2ServerResponse);
});
Loading