Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prepare the project for the new bun ecosystem #11445

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Jan 30, 2025

What are you trying to accomplish?

This PR lays the ground work towards supporting the new bun ecosystem

Part of https://github.com/github/dependabot-updates/issues/8148
Contributes to #6528

Anything you want to highlight for special attention from reviewers?

We are adding the zeitwork gem, as used in Ruby on Rails` to autoload files based on the conventions. We will progressively introduce this starting with the bun ecosystem. Existing ecosystems should not be impacted.

How will you know you've accomplished your goal?

We can ./bin/docker-dev-shell javascript

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Deleted PR

For some reason the same branch shows more changes in this PR, so we created this new one.

@markhallen markhallen requested a review from a team as a code owner January 30, 2025 10:31
@markhallen markhallen force-pushed the markhallen/prepare-for-new-bun-ecosystem branch from 5f5b838 to cb6318b Compare January 30, 2025 11:02
@markhallen markhallen requested a review from a team as a code owner February 4, 2025 13:37
@markhallen markhallen force-pushed the markhallen/prepare-for-new-bun-ecosystem branch from e99eb63 to b3daaad Compare February 4, 2025 13:56
robaiken
robaiken previously approved these changes Feb 4, 2025
@markhallen markhallen force-pushed the markhallen/prepare-for-new-bun-ecosystem branch from b3daaad to c4ef587 Compare February 4, 2025 14:17
robaiken
robaiken previously approved these changes Feb 4, 2025
@markhallen markhallen force-pushed the markhallen/prepare-for-new-bun-ecosystem branch from b11bb01 to c4ef587 Compare February 4, 2025 14:36
@@ -1,4 +1,4 @@
# typed: true
# typed: strict
Copy link
Contributor Author

@markhallen markhallen Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running spoom in CI insisted that the file dotnet_sdk/spec/spec_helper.rb be bumped from typed: true to typed: strict. This was blocking.

@markhallen markhallen merged commit fc8025f into main Feb 4, 2025
148 of 152 checks passed
@markhallen markhallen deleted the markhallen/prepare-for-new-bun-ecosystem branch February 4, 2025 15:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants