Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Prepare the project for the new bun ecosystem #11441

Closed
wants to merge 1 commit into from
Closed

Prepare the project for the new bun ecosystem #11441

wants to merge 1 commit into from

Conversation

markhallen
Copy link
Contributor

What are you trying to accomplish?

This PR lays the ground work towards supporting the new bun ecosystem

Part of https://github.com/github/dependabot-updates/issues/8148
Contributes to #6528

Anything you want to highlight for special attention from reviewers?

We are adding the zeitwork gem, as used in Ruby on Rails` to autoload files based on the conventions. We will progressively introduce this starting with the bun ecosystem. Existing ecosystems should not be impacted.

How will you know you've accomplished your goal?

We can ./bin/docker-dev-shell javascript

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner January 29, 2025 16:19
abdulapopoola
abdulapopoola reviewed Jan 29, 2025
View reviewed changes
javascript/spec/spec_helper.rb Outdated
@@ -0,0 +1,12 @@
# typed: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this strict to start with?

@markhallen markhallen mentioned this pull request Jan 29, 2025
Closed
5 tasks
@markhallen markhallen closed this Jan 30, 2025
@markhallen markhallen force-pushed the markhallen/prepare-for-new-bun-ecosystem branch from b850251 to c35e3b3 Compare January 30, 2025 10:12
@markhallen markhallen requested a review from a team as a code owner January 30, 2025 10:12
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: docker Docker containers L: rust:cargo Rust crates via cargo L: java:maven Maven packages via Maven L: javascript L: devcontainers L: dotnet-sdk labels Jan 30, 2025
This was referenced Jan 30, 2025
Merged
Draft
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola left review comments

Assignees
No one assigned
Labels
L: devcontainers L: docker Docker containers L: dotnet-sdk L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markhallen @abdulapopoola