Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add the bun ecosystem file fetcher #11446

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Jan 30, 2025

What are you trying to accomplish?

This PR adds the bun ecosystems basic files and FileFetcher.

Follow up to #11441

Part of https://github.com/github/dependabot-updates/issues/8148
Contributes to #6528

Anything you want to highlight for special attention from reviewers?

We added the zeitwerk gem for autoloading. This is used in Ruby on Rails to lazy load required files based on class and file naming conventions. A small number of shared files do not match the conventions and need to be ignored in zeitwerk and manually required as needed until the files themselves can be reorganised.

The FileFetcher is currently guarded with allow_beta_ecosystems? && Experiments.enabled?(:enable_bun_ecosystem) to control rollout and usage.

How will you know you've accomplished your goal?

rspec spec/dependabot/bun/ specs should pass.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Deleted PR

A failed rebase caused the previous PR to close.

@markhallen markhallen force-pushed the markhallen/bun-ecosystem-fetcher branch from 1e6dd76 to 5a813e2 Compare January 30, 2025 10:52
@markhallen markhallen force-pushed the markhallen/prepare-for-new-bun-ecosystem branch from 5f5b838 to cb6318b Compare January 30, 2025 11:02
@markhallen markhallen force-pushed the markhallen/bun-ecosystem-fetcher branch 2 times, most recently from 17331d4 to 0aa97d7 Compare February 4, 2025 13:01
@markhallen markhallen force-pushed the markhallen/prepare-for-new-bun-ecosystem branch from e99eb63 to b3daaad Compare February 4, 2025 13:56
@markhallen markhallen force-pushed the markhallen/prepare-for-new-bun-ecosystem branch from b3daaad to c4ef587 Compare February 4, 2025 14:17
@markhallen markhallen force-pushed the markhallen/bun-ecosystem-fetcher branch from 3ae9781 to 0fec2af Compare February 4, 2025 15:12
Base automatically changed from markhallen/prepare-for-new-bun-ecosystem to main February 4, 2025 15:47
@markhallen markhallen force-pushed the markhallen/bun-ecosystem-fetcher branch from 0fec2af to ad7f616 Compare February 4, 2025 15:54
javascript/lib/dependabot/javascript/file_fetcher_helper.rb Dismissed Show dismissed Hide dismissed
javascript/lib/dependabot/javascript/file_fetcher_helper.rb Dismissed Show dismissed Hide dismissed
javascript/lib/dependabot/javascript/file_fetcher_helper.rb Dismissed Show dismissed Hide dismissed
javascript/lib/dependabot/javascript/requirement.rb Dismissed Show dismissed Hide dismissed
javascript/lib/dependabot/javascript/version.rb Dismissed Show dismissed Hide dismissed
@markhallen markhallen force-pushed the markhallen/bun-ecosystem-fetcher branch from ad7f616 to 3266104 Compare February 4, 2025 16:15
@markhallen markhallen force-pushed the markhallen/bun-ecosystem-fetcher branch from 3266104 to 8b1a399 Compare February 5, 2025 13:21
@markhallen markhallen marked this pull request as ready for review February 5, 2025 13:59
@markhallen markhallen requested a review from a team as a code owner February 5, 2025 13:59
@markhallen markhallen merged commit a670542 into main Feb 5, 2025
54 checks passed
@markhallen markhallen deleted the markhallen/bun-ecosystem-fetcher branch February 5, 2025 15:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants