Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add required javascript file to fix dry run script #11490

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Feb 5, 2025

What are you trying to accomplish?

When splitting up PRs for the introduction of the bun ecosystem we missed a required file in the first PR.

Resolves #11483

How will you know you've accomplished your goal?

The dry run script should no longer raise an error when it encounters the line require "dependabot/javascript" in bin/dry-run.rb:114.

[dependabot-core-dev] ~ $ ./bin/dry-run.rb 
usage: ruby bin/dry-run.rb [OPTIONS] PACKAGE_MANAGER REPO
        --provider PROVIDER          SCM provider e.g. github, azure, bitbucket
        --dir DIRECTORY              Dependency file directory
        --branch BRANCH              Repo branch
        --dep DEPENDENCIES           Comma separated list of dependencies to update
        --cache STEPS                Cache e.g. files, dependencies
        --write                      Write the update to the cache directory
        --reject-external-code       Reject external code
        --requirements-update-strategy STRATEGY
                                     Options: lockfile_only, auto, widen_ranges, bump_versions or bump_versions_if_necessary
        --commit COMMIT              Commit to fetch dependency files from
        --vendor-dependencies        Vendor dependencies
        --updater-options OPTIONS    Comma separated list of updater options, available options depend on PACKAGE_MANAGER
        --security-updates-only      Only update vulnerable dependencies
        --profile                    Profile using Stackprof. Output in `tmp/stackprof-<datetime>.dump`
        --pull-request               Output pull request information metadata: title, description
        --enable-beta-ecosystems     Enable beta ecosystems
[dependabot-core-dev] ~ $ 

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner February 5, 2025 12:07
@markhallen markhallen enabled auto-merge February 5, 2025 13:02
@markhallen markhallen merged commit a03c47b into main Feb 5, 2025
54 checks passed
@markhallen markhallen deleted the markhallen/add-required-javascript-file branch February 5, 2025 13:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dry run script does not work
2 participants