Add preliminary support for compiling on Linux #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source/../types.h:35:10: fatal error: DiabloUI/_diabloui.h: No such file or directory
#include "DiabloUI/_diabloui.h"
---
Source/../Source/init.h:43:109: error: fastcall and stdcall attributes are not compatible
LRESULT (__stdcall *__fastcall SetWindowProc(void *func))(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam);
---
Source/missiles.cpp:915:27: error: unable to find numeric literal operator ‘operator""i64’
*(_QWORD *)&Dirs[0][2] = 0i64;
---
Source/world.cpp:38:1: error: narrowing conversion of ‘3937053354’ from ‘unsigned int’ to ‘int’ inside { } [-Wnarrowing]
---
Source/lighting.cpp:429:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing]
---
Source/objects.cpp:5459:62: error: unable to find numeric literal operator ‘operator""i64’
while ( !(plr[v53]._pMemSpells[1] & ((unsigned __int64)(1i64 << v60) >> 32) | plr[v53]._pMemSpells[0] & (unsigned int)(1i64 << v60)) );
---
Source/control.cpp:488:9: error: unable to find numeric literal operator ‘operator""i64’
v26 = 1i64;
---
Source/objects.cpp:243:1: error: narrowing conversion of ‘255’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/gamemenu.cpp:22:1: error: narrowing conversion of ‘2147483648’ from ‘unsigned int’ to ‘int’ inside { } [-Wnarrowing]
---
Source/sound.cpp:41:88: error: narrowing conversion of ‘240’ from ‘unsigned int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/quests.cpp:46:1: error: narrowing conversion of ‘255’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/player.cpp:4666:8: error: unable to find numeric literal operator ‘operator""i64’
v14 = 0i64;
---
Source/init.cpp:546:109: error: fastcall and stdcall attributes are not compatible
LRESULT (__stdcall *__fastcall SetWindowProc(void *func))(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
---
Source/items.cpp:114:1: error: narrowing conversion of ‘(item_effect_type)255’ from ‘unsigned int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/items.cpp:307:1: error: narrowing conversion of ‘(unique_base_item)255’ from ‘unsigned int’ to ‘char’ inside { } [-Wnarrowing]
---
Source/items.cpp:854:8: error: unable to find numeric literal operator ‘operator""i64’
v37 = 0i64;
---
Source/items.cpp:471:1: error: narrowing conversion of ‘(item_equip_type)255’ from ‘unsigned int’ to ‘char’ inside { } [-Wnarrowing]
* add aliases for storm exports to handle __stdcall calling convention on Linux * mark external functions as extern "C"
ghost
merged commit 
|
This is awesome. Thanks. |
|
Thanks for taking the time to do this. I'm going to take a break for awhile from working on Devilution. Edit: See merged request #4 I found out the reason menus are now broke is because of this change: The menus will work just fine if you change it back to a signed integer. |
|
Ah ok. I'll update and send a new PR. |
You most definitely deserve a break :) Andrew, would you consider adding @fearedbliss and myself as contributors to the repo? That way we can continue to commit changes without bothering you too much during your down time. Have a great summer! Cheers, |
|
No need to add me on here, I only mod d2 and I'm trying to not mod d2 that much anynore as well. |
nomdenom
pushed a commit
to nomdenom/devilution
that referenced
this pull request
Sep 13, 2018
monster.cpp: first cleanups
mewmew
pushed a commit
that referenced
this pull request
Oct 1, 2018
* clean GetSaveDirectory and pfile_read_hero clean pfile_open_save_archive clean pfile_archive_contains_game clean pfile_get_player_class clean pfile_get_file_name clean GetTempSaveNames clean GetPermSaveNames clean pfile_update clean pfile_init_save_directory clean pfile_write_hero clean pfile_open_archive clean pfile_flush_W * add stub for mpqapi_update_multi_creation_time
mewmew
pushed a commit
that referenced
this pull request
Mar 14, 2019
AJenbo
added a commit
that referenced
this pull request
Mar 19, 2019
Co-Authored-By: qndel <stefan551@o2.pl>
AJenbo
pushed a commit
that referenced
this pull request
Oct 11, 2020
This pull request was closed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works mostly. Can start a new game, walk around in town, enter the Cathedral and kill monsters.
What does not work currently is in game menus. It is possible to open the main menu by pressing ESC, but after that up and down arrows do not work and it does not respond to mouse actions. This is most likely because diabloui.dll has not been linked correctly.