Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

GCE driver should name the instance after the machine name #227

Closed
proppy opened this issue Jan 6, 2015 · 4 comments
Closed

GCE driver should name the instance after the machine name #227

proppy opened this issue Jan 6, 2015 · 4 comments

Comments

@proppy
Copy link
Contributor

proppy commented Jan 6, 2015

It would be nice if machine created with the GCE driver (and others) would be named (or even prefixed) after the machine name by default if no flag value for --google-instance-name is specified.

The current behavior is a bit confusing as machine will create multiple machine with the same underlying VM, if you don't specific --google-instance-name.

proppy@noir:~$ machine create --driver google --google-project proppy-stuff foo
proppy@noir:~$ machine create --driver google --google-project proppy-stuff bar
FATA[0004] Instance docker-machine already exists.
proppy@noir:~$ machine ls
NAME             ACTIVE   DRIVER   STATE     URL
bar              google   Running   tcp://130.211.144.5:2376
foo     *        google   Running   tcp://130.211.144.5:2376

Possibly related to #59 #219
/cc @dlorenc

@sthulb
Copy link
Contributor

sthulb commented Jan 6, 2015

All machines will take the name from the command as the VM name in whatever account/hypervisor

@proppy
Copy link
Contributor Author

proppy commented Jan 6, 2015

@sthulb that doesn't seems to be the case right now, at least for GCE:
https://github.com/docker/machine/blob/master/drivers/google/google.go#L96

@sthulb
Copy link
Contributor

sthulb commented Jan 6, 2015

Not right now. It's something I'm working on for #59

@ehazlett
Copy link
Contributor

ehazlett commented Jan 6, 2015

Closing as #59 will handle this (as @sthulb mentioned).

@ehazlett ehazlett closed this as completed Jan 6, 2015
tomeon pushed a commit to tomeon/machine that referenced this issue May 9, 2018
Point to the standalone go-boot2docker repo
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants