Hostnames #219

sthulb · 2015-01-05T16:46:05Z

This work sets the machine name in the Cloud API or Hypervisor. As well
as setting the hostname inside the VM.

I've added the machine name to the NewDriver func to allow for
identification by Cloud APIs and for the driver package.

Each driver will attempt to set the hostname for the VM, except for
Azure, which sets it based on the DNS name.

Refs: #59

ehazlett · 2015-01-05T22:57:25Z

drivers/virtualbox/virtualbox.go

@@ -363,6 +363,14 @@ func (d *Driver) Create() error {
 		return err
 	}

+	cmd, err = d.GetSSHCommand(fmt.Sprintf("sudo hostname %s", d.MachineName))


I don't believe this will persist reboots will it (need to update /etc/hostname at least).

Does that persist on boot2docker? Perhaps we don't bother setting the hostname on boot2docker... I think the big win from this pull request is the correct name showing up in your cloud provider's admin (e.g. list of instances on EC2), not the hostname when you log in.

You're right, it won't persist reboots. However one needs to update /usr/local/etc/hostname for it to persist on a b2d image.

@bfirsh I'm going for naming all of the things.

bfirsh · 2015-01-06T10:30:04Z

Thanks for this @sthulb. The bit I'm really interested in is setting the correct name on cloud providers. E.g. on Digital Ocean, removing the concept of DropletName and just making the name of the droplet the name of the host.

sthulb · 2015-01-06T12:17:37Z

EC2 support is kind of there, I can tag an instance with the machine ID, just the internal hostname remaining.

sthulb · 2015-01-06T15:21:33Z

I moved how we set the hostname to the driver.Create func since different drivers need the hostname func to be called at different times.

ehazlett · 2015-01-06T18:05:36Z

drivers/amazonec2/amazonec2.go

@@ -225,9 +228,32 @@ func (d *Driver) Create() error {
 		return err
 	}

+	log.Infof("Settings tags for instance")


This should probably be Debug

If you prefer :)

ehazlett · 2015-01-06T18:09:28Z

@sthulb i like this so far -- good work!

bfirsh · 2015-01-07T10:48:59Z

Great stuff. Since a driver is always attached to a machine, perhaps the name should be passed to NewDriver?

sthulb · 2015-01-07T10:56:45Z

@bfirsh It's something that should be considered when we need it in other places, but for now, I think leaving it on Create(name string) seems ok.

sthulb · 2015-01-07T11:20:47Z

@bfirsh I take back my comment... azure kind of forces your idea.

sthulb · 2015-01-07T14:36:12Z

@bfirsh @ehazlett I think it's finished. someone should perhaps test the Azure & Google drivers

ehazlett · 2015-01-07T17:18:08Z

awesome! thanks -- I will check it out

On Wed, Jan 7, 2015 at 6:36 AM, Simon Thulbourn notifications@github.com
wrote:

@bfirsh https://github.com/bfirsh @ehazlett
https://github.com/ehazlett I think it's finished. someone should
perhaps test the Azure & Google drivers

—
Reply to this email directly or view it on GitHub
#219 (comment).

ehazlett · 2015-01-07T20:58:04Z

I'm getting "sudo: unable to resolve host test-ec2" with amazonec2. The hostname isn't added to /etc/hosts. You may need to silence this for the first sudo to add it but I think it would be good otherwise it will spit this out for every sudo command.

sthulb · 2015-01-07T21:25:01Z

I'll alter the PR to add to the hosts file also.

ehazlett · 2015-01-07T21:49:31Z

@sthulb thanks

ehazlett · 2015-01-08T01:24:46Z

@sthulb i'm also getting the following with azure:

FATA[0004] A hosted service with the specified name already exists.

It's not happening in master.

sthulb · 2015-01-08T10:58:06Z

I've fixed the sudo thing.

sthulb · 2015-01-08T11:34:08Z

So Azure likes globally unique names... so the best we can do is: foo-<timestamp> for azure, which sucks. Unless someone knows differently?

jeffmendoza · 2015-01-08T16:56:48Z

In Azure, your VM sits inside a "Cloud Service." The cloud service must have a globally unique name, as it's used for DNS: .cloudapp.net. The VM can have any name, and that will be the hostname of the VM.

ehazlett · 2015-01-08T17:33:33Z

@sthulb i think naming with a unique/timestamp is fine. it's just the cloud service and not the actual VM hostname which is what we want to name anyway.

ehazlett · 2015-01-08T17:50:56Z

@sthulb sorry to be nitpicky but I'm still getting a couple sudo: unable to resolve host test-ec2. We may need to > /dev/null 2>&1 or something to hide the initial set. wdyt?

sthulb · 2015-01-08T20:33:20Z

That's fine, ... I just need to track down the origin of it...

sthulb · 2015-01-09T09:20:49Z

@ehazlett This should be good to merge now.

ehazlett · 2015-01-09T18:17:52Z

@sthulb Hmm I keep getting this error with EC2:

Error creating host: Error decoding error response: Error decoding error response: http: read on closed response body

Have you ran into that?

sthulb · 2015-01-09T18:28:29Z

Not at all.

ehazlett · 2015-01-09T18:40:03Z

Hmm ok -- may be AWS. I'll try again -- thx

sthulb · 2015-01-09T18:46:28Z

Perhaps we can get @bfirsh try it too.

ehazlett · 2015-01-09T18:53:23Z

@sthulb can you do a fresh build and confirm it's not doing it? It's not doing it to me in master.

ehazlett · 2015-01-09T18:53:43Z

@sthulb +1 /cc @bfirsh

bfirsh · 2015-01-09T19:38:05Z

drivers/digitalocean/digitalocean.go

@@ -147,9 +145,24 @@ func (d *Driver) Create() error {
 		return err
 	}

+	log.Debugf("Setting hostname: %s", d.MachineName)
+	cmd, err := d.GetSSHCommand(fmt.Sprintf(
+		"echo \"127.0.0.1 %s\" | sudo tee -a /etc/hosts && sudo hostname %s && echo \"%s\" | sudo tee /etc/hostname",


Doesn't Digital Ocean set the hostname to be the droplet name?

sthulb · 2015-01-09T22:21:40Z

@ehazlett I think I've figured out why you get it... By any chance, do you already have a security group with the same group name?

ehazlett · 2015-01-09T23:44:51Z

yep. looks like it was left over from a previous run. i will remove and
test. thanks!

On Fri, Jan 9, 2015 at 2:21 PM, Simon Thulbourn notifications@github.com
wrote:

@ehazlett https://github.com/ehazlett I think I've figured out why you
get it... By any chance, do you already have a security group with the same
group name?

—
Reply to this email directly or view it on GitHub
#219 (comment).

This work sets the machine name in the Cloud API or Hypervisor. As well as setting the hostname inside the VM. I've added the machine name to the NewDriver func to allow for identification by Cloud APIs and for the driver package. Each driver will attempt to set the hostname for the VM, except for Azure, which sets it based on the DNS name. Signed-off-by: Simon Thulbourn <simon+github@thulbourn.com>

ehazlett · 2015-01-14T14:31:38Z

LGTM

Hostnames

Improved boot2docker.go

ehazlett reviewed Jan 5, 2015
View reviewed changes

proppy mentioned this pull request Jan 6, 2015

GCE driver should name the instance after the machine name #227

Closed

ehazlett reviewed Jan 6, 2015
View reviewed changes

sthulb changed the title ~~[wip] Hostnames~~ Hostnames Jan 7, 2015

sthulb mentioned this pull request Jan 7, 2015

VMware host drivers for Fusion, vSphere and vCloud Air #6

Merged

bfirsh mentioned this pull request Jan 9, 2015

weird failure creating a do machine #243

Closed

sthulb mentioned this pull request Jan 9, 2015

Use "standard" TLS instead of identity auth #254

Closed

bfirsh reviewed Jan 9, 2015
View reviewed changes

ehazlett added a commit that referenced this pull request Jan 14, 2015

Merge pull request #219 from sthulb/hostnames

c2f1fea

Hostnames

ehazlett merged commit c2f1fea into docker:master Jan 14, 2015

ehazlett mentioned this pull request Jan 14, 2015

Set the hostname of created machines to match the machine name #59

Closed

sthulb deleted the hostnames branch January 16, 2015 16:15

chanezon mentioned this pull request Jan 28, 2015

when using the azure driver, --azure-name parameter is not used #419

Closed

ahmetb mentioned this pull request Jan 29, 2015

[Azure driver] Allow custom DNS (cloud service) names #433

Closed

tomeon pushed a commit to tomeon/machine that referenced this pull request May 9, 2018

Merge pull request docker#219 from riobard/go

1e4eba1

Improved boot2docker.go

Hostnames #219

Hostnames #219

Conversation

sthulb commented Jan 5, 2015

ehazlett Jan 5, 2015

Choose a reason for hiding this comment

bfirsh Jan 6, 2015

Choose a reason for hiding this comment

sthulb Jan 6, 2015

Choose a reason for hiding this comment

sthulb Jan 6, 2015

Choose a reason for hiding this comment

bfirsh commented Jan 6, 2015

sthulb commented Jan 6, 2015

sthulb commented Jan 6, 2015

ehazlett Jan 6, 2015

Choose a reason for hiding this comment

sthulb Jan 7, 2015

Choose a reason for hiding this comment

ehazlett commented Jan 6, 2015

bfirsh commented Jan 7, 2015

sthulb commented Jan 7, 2015

sthulb commented Jan 7, 2015

sthulb commented Jan 7, 2015

ehazlett commented Jan 7, 2015

ehazlett commented Jan 7, 2015

sthulb commented Jan 7, 2015

ehazlett commented Jan 7, 2015

ehazlett commented Jan 8, 2015

sthulb commented Jan 8, 2015

sthulb commented Jan 8, 2015

jeffmendoza commented Jan 8, 2015

ehazlett commented Jan 8, 2015

ehazlett commented Jan 8, 2015

sthulb commented Jan 8, 2015

sthulb commented Jan 9, 2015

ehazlett commented Jan 9, 2015

sthulb commented Jan 9, 2015

ehazlett commented Jan 9, 2015

sthulb commented Jan 9, 2015

ehazlett commented Jan 9, 2015

ehazlett commented Jan 9, 2015

bfirsh Jan 9, 2015

Choose a reason for hiding this comment

sthulb commented Jan 9, 2015

ehazlett commented Jan 9, 2015

ehazlett commented Jan 14, 2015