Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dep: bump cainome to 0.14.12 #2973

Merged
merged 1 commit into from
Jan 29, 2025
Merged

dep: bump cainome to 0.14.12 #2973

merged 1 commit into from
Jan 29, 2025

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 29, 2025

Summary by CodeRabbit

  • Dependencies

    • Updated cainome dependency from version v0.4.11 to v0.4.12
  • Refactor

    • Restructured contract ABI definition for improved readability

Copy link

coderabbitai bot commented Jan 29, 2025

Walkthrough

Ohayo, sensei! This pull request involves two primary changes: updating the cainome dependency version from v0.4.11 to v0.4.12 in the Cargo.toml file, and modifying the ABI definition for the AppchainContract in the deployment.rs file. The dependency update ensures the project uses the latest version of the library, while the ABI definition is restructured from a single string to an array of JSON objects for improved readability.

Changes

File Change Summary
Cargo.toml Updated cainome dependency from v0.4.11 to v0.4.12 in workspace dependencies
bin/katana/src/cli/init/deployment.rs Restructured abigen! macro for AppchainContract from single string ABI to array of JSON objects

Possibly related PRs


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 010bf80 and 5f447de.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • bin/katana/src/cli/init/deployment.rs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • bin/katana/src/cli/init/deployment.rs

Comment on lines +73 to 74
cainome = { git = "https://github.com/cartridge-gg/cainome", tag = "v0.4.12", features = [ "abigen-rs" ] }
cainome-cairo-serde = { git = "https://github.com/cartridge-gg/cainome", tag = "v0.4.11" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Ohayo sensei! The version bump looks good, but let's align the versions.

  1. The PR title's 0.14.12 appears to be a typo for 0.4.12 (confirmed via tags).
  2. Both cainome and cainome-cairo-serde should use v0.4.12. The update from v0.4.11 only adds JSON ABI embedding support with no breaking changes, so it's safe to align both versions.
🔗 Analysis chain

Ohayo sensei! Please verify the version numbers and ensure consistency.

Two concerns to address:

  1. The PR title mentions 0.14.12 but the actual change is to 0.4.12. Could you confirm the intended version?
  2. cainome and cainome-cairo-serde have different versions (v0.4.12 vs v0.4.11). Since they're from the same repository, they should typically use the same version to avoid potential compatibility issues.

Let's check the available versions and any breaking changes:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify cainome versions and changes

# Check the repository for available versions and changes
echo "Checking available versions..."
gh api repos/cartridge-gg/cainome/tags --jq '.[0:5] | .[] | .name'

# Check for breaking changes between v0.4.11 and v0.4.12
echo -e "\nChecking for breaking changes..."
gh api repos/cartridge-gg/cainome/compare/v0.4.11...v0.4.12 --jq '.commits[].commit.message'

Length of output: 565

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 57.12%. Comparing base (010bf80) to head (5f447de).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bin/katana/src/cli/init/deployment.rs 0.00% 52 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2973      +/-   ##
==========================================
- Coverage   57.18%   57.12%   -0.06%     
==========================================
  Files         423      423              
  Lines       56147    56189      +42     
==========================================
- Hits        32105    32097       -8     
- Misses      24042    24092      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit 0adbcdd into main Jan 29, 2025
13 of 15 checks passed
@kariy kariy deleted the bump-cainome branch January 29, 2025 23:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant