Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dep: bump cainome to 0.14.12 #2973

Merged
merged 1 commit into from
Jan 29, 2025
Merged

dep: bump cainome to 0.14.12 #2973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 112 additions & 14 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ debug = true
inherits = "release"

[workspace.dependencies]
cainome = { git = "https://github.com/cartridge-gg/cainome", tag = "v0.4.11", features = [ "abigen-rs" ] }
cainome = { git = "https://github.com/cartridge-gg/cainome", tag = "v0.4.12", features = [ "abigen-rs" ] }
cainome-cairo-serde = { git = "https://github.com/cartridge-gg/cainome", tag = "v0.4.11" }
Comment on lines +73 to 74
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Ohayo sensei! The version bump looks good, but let's align the versions.

  1. The PR title's 0.14.12 appears to be a typo for 0.4.12 (confirmed via tags).
  2. Both cainome and cainome-cairo-serde should use v0.4.12. The update from v0.4.11 only adds JSON ABI embedding support with no breaking changes, so it's safe to align both versions.
🔗 Analysis chain

Ohayo sensei! Please verify the version numbers and ensure consistency.

Two concerns to address:

  1. The PR title mentions 0.14.12 but the actual change is to 0.4.12. Could you confirm the intended version?
  2. cainome and cainome-cairo-serde have different versions (v0.4.12 vs v0.4.11). Since they're from the same repository, they should typically use the same version to avoid potential compatibility issues.

Let's check the available versions and any breaking changes:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify cainome versions and changes

# Check the repository for available versions and changes
echo "Checking available versions..."
gh api repos/cartridge-gg/cainome/tags --jq '.[0:5] | .[] | .name'

# Check for breaking changes between v0.4.11 and v0.4.12
echo -e "\nChecking for breaking changes..."
gh api repos/cartridge-gg/cainome/compare/v0.4.11...v0.4.12 --jq '.commits[].commit.message'

Length of output: 565

dojo-utils = { path = "crates/dojo/utils" }

Expand Down
62 changes: 52 additions & 10 deletions bin/katana/src/cli/init/deployment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,58 @@
#[rustfmt::skip]
abigen!(
AppchainContract,
"[{\"type\":\"function\",\"name\":\"set_program_info\",\"inputs\":[{\"name\":\"\
program_hash\",\"type\":\"core::Felt\"},{\"name\":\"config_hash\",\"type\":\"\
core::Felt\"}],\"outputs\":[],\"state_mutability\":\"external\"},{\"type\":\"\
function\",\"name\":\"set_facts_registry\",\"inputs\":[{\"name\":\"address\",\"type\"\
:\"core::starknet::contract_address::ContractAddress\"}],\"outputs\":[],\"\
state_mutability\":\"external\"},{\"type\":\"function\",\"name\":\"\
get_facts_registry\",\"inputs\":[],\"outputs\":[{\"type\":\"\
core::starknet::contract_address::ContractAddress\"}],\"state_mutability\":\"view\"},\
{\"type\":\"function\",\"name\":\"get_program_info\",\"inputs\":[],\"outputs\":[{\"\
type\":\"(core::Felt, core::Felt)\"}],\"state_mutability\":\"view\"}]"
[
{
"type": "function",
"name": "set_program_info",
"inputs": [
{
"name": "program_hash",
"type": "core::Felt"
},
{
"name": "config_hash",
"type": "core::Felt"
}
],
"outputs": [],
"state_mutability": "external"
},
{
"type": "function",
"name": "set_facts_registry",
"inputs": [
{
"name": "address",
"type": "core::starknet::contract_address::ContractAddress"
}
],
"outputs": [],
"state_mutability": "external"
},
{
"type": "function",
"name": "get_facts_registry",
"inputs": [],
"outputs": [
{
"type": "core::starknet::contract_address::ContractAddress"
}
],
"state_mutability": "view"
},
{
"type": "function",
"name": "get_program_info",
"inputs": [],
"outputs": [
{
"type": "(core::Felt, core::Felt)"
}
],
"state_mutability": "view"
}
]

Check warning on line 83 in bin/katana/src/cli/init/deployment.rs

View check run for this annotation

Codecov / codecov/patch

bin/katana/src/cli/init/deployment.rs#L32-L83 

Added lines #L32 - L83 were not covered by tests
);

const PROGRAM_HASH: Felt =
Expand Down
Loading