Skip to content

Perf regression in Attach #22263

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
smitpatel opened this issue Aug 27, 2020 · 1 comment · Fixed by #22275
Closed

Perf regression in Attach #22263

smitpatel opened this issue Aug 27, 2020 · 1 comment · Fixed by #22275
Assignees
@smitpatel
Labels
area-perf type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Contributor

image

Also AttachChildren/AttachParents scenarios.

@dotnet/efteam - Does anyone know the faulty commit. I will start bisecting on git tomorrow morning if no one knows.
@smitpatel smitpatel mentioned this issue Aug 27, 2020
Merged
@AndriySvyryd
Copy link
Member

My guess would be 04575b0

@smitpatel smitpatel self-assigned this Aug 27, 2020
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation
e9c8347 
Resolves #22263

Also improves perf for Add
@smitpatel smitpatel added this to the 5.0.0-rc1 milestone Aug 27, 2020
@smitpatel smitpatel mentioned this issue Aug 27, 2020
Merged
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation
58c065c 
Resolves #22263

Also improves perf for Add
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation
df33907 
Resolves #22263

Also improves perf for Add
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation
ed2b531 
Resolves #22263

Also improves perf for Add
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation
4cf3f39 
Resolves #22263

Also improves perf for Add
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation
ef3f460 
Resolves #22263

Also improves perf for Add
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation
c884811 
Resolves #22263

Also improves perf for Add
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation
97e2366 
Resolves #22263

Also improves perf for Add
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache candidate properties for propagation and generation (#22275)
a29f30c 
Resolves #22263

Also improves perf for Add
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@smitpatel smitpatel

Labels
area-perf type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Perf: Cache candidate properties for propagation and generation dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd