Skip to content

Perf: Cache candidate properties for propagation and generation #22275

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2020
Merged

Perf: Cache candidate properties for propagation and generation #22275

merged 1 commit into from
Aug 27, 2020

Conversation

smitpatel
Copy link
Contributor

Resolves #22263

Also improves perf for Add

@smitpatel
Copy link
Contributor Author

Before

Method AutoDetectChanges Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Add False 221.1 ms 2.28 ms 2.13 ms 9000.0000 3000.0000 - 59.13 MB
AddRange False 225.7 ms 1.20 ms 1.12 ms 9000.0000 3000.0000 - 58.52 MB
Attach False 169.6 ms 1.88 ms 1.76 ms 7000.0000 2000.0000 - 45.4 MB
AttachRange False 162.5 ms 1.51 ms 1.41 ms 7000.0000 2000.0000 - 44.79 MB
Add True 220.8 ms 1.72 ms 1.61 ms 9000.0000 3000.0000 - 59.13 MB
AddRange True 230.4 ms 1.94 ms 1.72 ms 9000.0000 3000.0000 - 58.52 MB
Attach True 171.8 ms 2.52 ms 2.24 ms 7000.0000 2000.0000 - 45.4 MB
AttachRange True 168.8 ms 1.23 ms 1.03 ms 7000.0000 2000.0000 - 44.79 MB

After

Method AutoDetectChanges Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Add False 143.66 ms 2.057 ms 1.925 ms 8000.0000 2000.0000 - 51.04 MB
AddRange False 139.75 ms 2.083 ms 1.948 ms 8000.0000 2000.0000 - 50.43 MB
Attach False 103.22 ms 0.933 ms 0.827 ms 6000.0000 2000.0000 - 41.28 MB
AttachRange False 96.17 ms 1.322 ms 1.236 ms 6000.0000 2000.0000 - 40.67 MB
Add True 167.29 ms 3.681 ms 5.160 ms 8000.0000 2000.0000 - 51.04 MB
AddRange True 140.94 ms 1.663 ms 1.556 ms 8000.0000 2000.0000 - 50.43 MB
Attach True 97.05 ms 1.154 ms 1.079 ms 6000.0000 2000.0000 - 41.28 MB
AttachRange True 99.18 ms 1.299 ms 1.215 ms 6000.0000 2000.0000 - 40.67 MB

@smitpatel smitpatel force-pushed the smit/attachperf branch 2 times, most recently from 58c065c to df33907 Compare August 27, 2020 18:54
@smitpatel smitpatel requested a review from AndriySvyryd August 27, 2020 18:56
@smitpatel smitpatel force-pushed the smit/attachperf branch 2 times, most recently from 4cf3f39 to ef3f460 Compare August 27, 2020 20:16
@smitpatel
Copy link
Contributor Author

After multiple options and iterations

Method AutoDetectChanges Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Add False 135.93 ms 2.422 ms 2.265 ms 7000.0000 2000.0000 - 49.52 MB
AddRange False 137.92 ms 2.183 ms 2.042 ms 7000.0000 2000.0000 - 48.91 MB
Attach False 96.86 ms 1.400 ms 1.241 ms 6000.0000 2000.0000 - 40.51 MB
AttachRange False 95.02 ms 0.916 ms 0.857 ms 6000.0000 2000.0000 - 39.9 MB
Add True 136.08 ms 1.233 ms 1.153 ms 7000.0000 2000.0000 - 49.52 MB
AddRange True 136.86 ms 2.007 ms 1.877 ms 7000.0000 2000.0000 - 48.91 MB
Attach True 103.01 ms 2.007 ms 3.298 ms 6000.0000 2000.0000 - 40.51 MB
AttachRange True 96.48 ms 1.304 ms 1.219 ms 6000.0000 2000.0000 - 39.9 MB

@smitpatel smitpatel requested a review from AndriySvyryd August 27, 2020 20:20
@smitpatel
Copy link
Contributor Author

@Pilchie for RC1 approval

@Pilchie
Copy link
Member

Pilchie commented Aug 27, 2020

Approved for RC.1

@smitpatel smitpatel merged commit a29f30c into release/5.0 Aug 27, 2020
@smitpatel smitpatel deleted the smit/attachperf branch August 27, 2020 23:23
@ajcvickers ajcvickers mentioned this pull request Sep 10, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perf regression in Attach
3 participants
@smitpatel @Pilchie @AndriySvyryd