Skip to content

Add missing Ordinal to {Starts,Ends}With #18873

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Add missing Ordinal to {Starts,Ends}With #18873

merged 1 commit into from
Nov 13, 2019

Conversation

roji
Copy link
Member

@roji roji commented Nov 12, 2019

Fixes #18831. We should also use analyzers (#18870) to make sure it doesn't happen again.

Mystery:

Tried to add a test. But mysteriously, the following yields False, True:

Console.WriteLine("__someName_0".StartsWith("@"));
Thread.CurrentThread.CurrentCulture = CultureInfo.GetCultureInfo("th-TH");
Console.WriteLine("__someName_0".StartsWith("@"));

But the same inside a test returns false for both... There's some environmental thing going on, but don't think it's worth digging into it.

@smitpatel
Copy link
Contributor

Look at EntityType_name_is_stored_culture_invariantly test. We have attribute to set custom culture for test.

@roji
Copy link
Member Author

roji commented Nov 13, 2019

@smitpatel yeah I tried that, but I can't get this to repro in the tests for some inexplicable reason - only in a console app. Merging as the test value seems a bit low here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify CultureInfo in Controller make query not working
3 participants