[dotnet-linker] Remove workaround for a dotnet/runtime issue wrt the AOT compiler. #12528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AOT compiler. The dotnet/runtime issue has been fixed. Ref: dotnet/runtime#55733
rolfbjarne
added
not-notes-worthy
spouliot
approved these changes
Aug 24, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 142 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur |
…/MonoBundlingExtraArgs to increase verbosity. This fixes a problem where a test project would try to set the MtouchExtraArgs/MonoBundlingExtraArgs properties, and it would fail because the MtouchExtraArgs/MonoBundlingExtraArgs properties were already set from the command line (and in MSBuild, properties that are set from command line arguments can't be changed later). In particular we have logic to pass --dlsym:+nunit.framework.dll for monotouch-test, and that would just be ignored.
chamons
approved these changes
Aug 25, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results36 tests failed, 107 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results5 tests failed, 138 tests passed.Failed tests
Pipeline on Agent XAMBOT-1102.BigSur' |
|
Waiting for #12570 to be merged first, then merge main into this PR and this PR should turn green. |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 142 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Now waiting for #12715 to be merged, then merge main into this PR and this PR will hopefully turn green. |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 135 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Test failures are unrelated:
|
61 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dotnet/runtime issue has been fixed.
Ref: dotnet/runtime#55733