[msbuild] Make the ParseBundlerArgumentsTaskBase take the verbosity as input as well. #12570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s input as well. This way we'll honor a _BundlerVerbosity value passed on the command line. This fixes an inconvenience when we have when we want to increase verbosity for a test run, which can be done by setting 'MtouchExtraArgs=-v'. This works fine until the test we want to run wants to use MtouchExtraArgs for its own purposes (1). If we set MtouchExtraArgs on the command line, then that value will be global and won't be able to be overridden by the test, and the test will fail. With this fix we can pass _BundlerVerbosity=1 directly when building the test to avoid the whole problem. 1. For instance, most tests pass an argument in MtouchExtraArgs to use dlsym for NUnit.Framework.dll, which contains a P/Invoke to a native function that doesn't exist - see the tests/nunit.framework.targets file.
rolfbjarne
added
not-notes-worthy
emaf
approved these changes
Aug 27, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 141 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
spouliot
approved these changes
Aug 30, 2021
dalexsoto
approved these changes
Aug 31, 2021
|
Test failures are unrelated (both due to #12569). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we'll honor a _BundlerVerbosity value passed on the command line.
This fixes an inconvenience when we have when we want to increase verbosity
for a test run, which can be done by setting 'MtouchExtraArgs=-v'. This works
fine until the test we want to run wants to use MtouchExtraArgs for its own
purposes (1). If we set MtouchExtraArgs on the command line, then that value
will be global and won't be able to be overridden by the test, and the test
will fail.
With this fix we can pass _BundlerVerbosity=1 directly when building the test
to avoid the whole problem.
dlsym for NUnit.Framework.dll, which contains a P/Invoke to a native function
that doesn't exist - see the tests/nunit.framework.targets file.